Add HeaderMenu component #2886
Closed
Add HeaderMenu component #2886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This component is used for the notification and full text search icon in the navbar. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| ], | ||
|
|
||
| props: { | ||
| id: { |
Contributor
There was a problem hiding this comment.
This could use some documentation, so it is shown nicely in the docs.
| v-click-outside="clickOutsideConfig" | ||
| :class="{ 'header-menu--opened': opened }" | ||
| class="header-menu"> | ||
| <a class="header-menu__trigger" |
Contributor
There was a problem hiding this comment.
I don't really know how the component is supposed to work/behave, but this looks like it could be a vue button, no?
Contributor
marcoambrosini
left a comment
marcoambrosini
left a comment
There was a problem hiding this comment.
The docs fail to build. Could you fix that or add screenshots?
Contributor
|
I suppose this PR was superseded by #3489, right? I will close the PR, reopen if I am wrong. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component is used for the notification and full-text search icon in
the navbar.
TODOS: