Skip to content

feat(NcActionButton): support menu styling #4724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 3 commits into from
Oct 31, 2023
Merged

feat(NcActionButton): support menu styling #4724

skjnldsv merged 3 commits into from
Oct 31, 2023

Conversation

@skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Oct 31, 2023 •
edited
Loading

Peek 31-10-2023 11-08

@skjnldsv
fix(actions): long text wrap
40dcf81 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
feat(NcActionButton): support menu styling
03cecfb 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews feature: actions Related to the actions components regression Regression of a previous working feature labels Oct 31, 2023
@skjnldsv skjnldsv self-assigned this Oct 31, 2023
@skjnldsv skjnldsv changed the title fix(actions): long text wrap feat(NcActionButton): support menu styling Oct 31, 2023
@skjnldsv skjnldsv mentioned this pull request Oct 31, 2023
Merged
ShGKme
ShGKme approved these changes Oct 31, 2023
View reviewed changes
@skjnldsv @ShGKme
fix(NcActionButton): code comment
d1b4a82 
Co-authored-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 31, 2023
@skjnldsv skjnldsv merged commit a956334 into master Oct 31, 2023
@skjnldsv skjnldsv deleted the feat/action-menu branch October 31, 2023 16:07
@skjnldsv skjnldsv mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@artonge artonge Awaiting requested review from artonge

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request feature: actions Related to the actions components regression Regression of a previous working feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv @raimund-schluessler @ShGKme