No notification email is sent when a file is uploaded into a shared folder by another user

[Nils160988]

Steps to reproduce

1. Create two users A and B
2. Make sure user B has checked the box "New file or folder has been created" of the activity settings
3. As user A, create a folder and share it with user B
4. As user A, create a file in that folder

Expected behaviour

Tell us what should happen
User B should receive a notification email which announces the share and another email, when the file has been uploaded into the shared folder

Actual behaviour

User B receives an email after the share, but not after the file upload. The same is true for folders which are created by the groupfolder app.

Server configuration

Server configuration detail

Operating system: Linux 4.4.0-042stab127.2 #1 SMP Thu Jan 4 16:41:44 MSK 2018 x86_64

Webserver: Apache (apache2handler)

Database: mysql 10.0.33

PHP version: 7.0.22-0ubuntu0.16.04.1
Modules loaded: Core, date, libxml, openssl, pcre, zlib, filter, hash, Reflection, SPL, session, standard, apache2handler, mysqlnd, PDO, xml, apcu, bz2, calendar, ctype, curl, dom, mbstring, fileinfo, ftp, gd, gettext, iconv, imagick, intl, json, exif, mcrypt, mysqli, pdo_mysql, Phar, posix, readline, shmop, SimpleXML, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xmlreader, xmlwriter, xsl, zip, Zend OPcache

Nextcloud version: 13.0.0 - 13.0.0.14

Updated from an older Nextcloud/ownCloud or fresh install:

Where did you install Nextcloud from: unknown

List of activated apps

Enabled:

• activity: 2.6.1
• bruteforcesettings: 1.0.3
• calendar: 1.6.0
• comments: 1.3.0
• contacts: 2.0.1
• dav: 1.4.6
• federatedfilesharing: 1.3.1
• federation: 1.3.0
• files: 1.8.0
• files_pdfviewer: 1.2.0
• files_sharing: 1.5.0
• files_texteditor: 2.5.1
• files_trashbin: 1.3.0
• files_versions: 1.6.0
• files_videoplayer: 1.2.0
• firstrunwizard: 2.2.1
• gallery: 18.0.0
• groupfolders: 1.2.0
• issuetemplate: 0.3.0
• logreader: 2.0.0
• lookup_server_connector: 1.1.0
• nextcloud_announcements: 1.2.0
• notifications: 2.1.2
• oauth2: 1.1.0
• password_policy: 1.3.0
• provisioning_api: 1.3.0
• quota_warning: 1.2.0
• serverinfo: 1.3.0
• sharebymail: 1.3.0
• spreed: 3.0.1
• survey_client: 1.1.0
• systemtags: 1.3.0
• theming: 1.4.1
• twofactor_backupcodes: 1.2.3
• updatenotification: 1.3.0
• workflowengine: 1.3.0
  Disabled:
• admin_audit
• encryption
• files_external
• ojsxc
• richdocuments
• user_external
• user_ldap

</details>

<details><summary>Configuration (config/config.php)</summary>

{
"instanceid": "REMOVED SENSITIVE VALUE",
"passwordsalt": "REMOVED SENSITIVE VALUE",
"secret": "REMOVED SENSITIVE VALUE",
"trusted_domains": [
REMOVED SENSITIVE VALUE
],
"datadirectory": "REMOVED SENSITIVE VALUE",
"overwrite.cli.url": "REMOVED SENSITIVE VALUE",
"dbtype": "mysql",
"version": "13.0.0.14",
"dbname": "REMOVED SENSITIVE VALUE",
"dbhost": "REMOVED SENSITIVE VALUE",
"dbport": "",
"dbtableprefix": "oc_",
"dbuser": "REMOVED SENSITIVE VALUE",
"dbpassword": "REMOVED SENSITIVE VALUE",
"installed": true,
"memcache.local": "\OC\Memcache\APCu",
"mail_smtpmode": "sendmail",
"mail_smtpauthtype": "LOGIN",
"mail_from_address": "REMOVED SENSITIVE VALUE",
"mail_domain": "REMOVED SENSITIVE VALUE",
"force_language": "de",
"htaccess.RewriteBase": "/",
"logtimezone": "Europe/Berlin",
"maintenance": false,
"theme": "",
"loglevel": 2,
"updater.release.channel": "beta",
"updater.secret": "REMOVED SENSITIVE VALUE"
}

Are you using external storage, if yes which one: no

Are you using encryption: no

Are you using an external user-backend, if yes which one: no

No relevant log entries

I already opened a thread in the forum (https://help.nextcloud.com/t/send-email-when-adding-file-in-groupfolder-edit-email-is-also-not-send-when-adding-file-in-regular-shared-folder/26907) because I am not sure whether this behavior is intentional or not.

[nickvergessen]

I'm not 100% sure, but did you try logging in with user B between 3 and 4?

[Nils160988]

I am not sure if I did.

I tried again with logging in as user B between 3 and 4. Same behavior.

Shouldn't it be independent from logging in or not?

[Nils160988]

I checked this behavior on a new nextcloud instance and might have some more info:

Notification E-Mails are sent if a file or a folder are shared with the other user.

No notification E-Mails are sent if a file or a folder are shared with the group, which both users belong to.

[denunv]

Can confirm the issue. We are on 13.0.0, php 7.1.9 and we get no email notification.

Notifications are only sent if the file or folder is shared, but not when something is added/updated in that folder.

The logging is only showing the background job messages, no error is shown.

[Nils160988]

Further testing shows, that it is the same for asap mode or hourly sent mails.

Any ideas how to address this issue?

[PiotrIr]

I have the same issue. Could you tell me when th issue will be fixed please?

[Nils160988]

Issue seems to be gone in version 13.0.1 RC1 :)
Works for both regularly shared folders and group-folders.
Edit: Typo

[nickvergessen]

I guess it was #249 or #252 then?

[Nils160988]

Without having checked, I would guess it was #252, because it did not depend on asap mode or not.

[Nils160988]

It still seems to be broken for groupfolders :(

So it works fine for shared folders, but it does not work for groupfolders. Can you reopen it @nickvergessen or should I open a new issue?

Edit: Now for Nextcloud 13.0.1