[stable-1.6] Defensive check for Log_OC arguments for null#341
Merged
Conversation
Log.d does not handle null, causing NPE thrown from native logger implementation. This defensive check ensures that legacy clients don't crash the system. Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
backportbot-nextcloud
Bot
requested review from
AndyScherzinger,
ezaquarii and
tobiasKaminsky
October 2, 2019 06:41
tobiasKaminsky
approved these changes
Oct 2, 2019
Collaborator
Lint
SpotBugs (new)
SpotBugs (stable-1.6)
|
Codecov Report
@@ Coverage Diff @@
## stable-1.6 #341 +/- ##
=============================================
Coverage ? 25.11%
=============================================
Files ? 120
Lines ? 5275
Branches ? 722
=============================================
Hits ? 1325
Misses ? 3787
Partials ? 163
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #338