Bring back logging arguments for external SD support#5
Merged
Conversation
Fix typos
First of, this will prevent logs mixing, sencondly this will allow user to safely migrate data even when other thread will call logging functions
AndyScherzinger
force-pushed
the
bring_back_logging_arguments
branch
from
a75e683 to
2b5bd6e
Compare
Member
|
I fixed the indentation, one thing I realized looking through the code, shouldn't we replace the system out println statements with standard Android log statements? |
Member
Author
|
@AndyScherzinger yes we should, but where is those used ? Whenever I see System.out.print* function call i replace it |
Member
Member
Author
|
Waiting for review :) |
Member
|
👍 |
Member
|
Can you have an look @tobiasKaminsky ? |
Member
Author
|
I wonder if I put myself a thumbs up will it work, since Andy is a coauthor now |
Member
Author
|
👍 |
Member
|
it probably only care about who actually opened the PR, besides the LGTM check seems to not work properly at the moment |
Member
|
LGTM |
AndyScherzinger
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for external SD support