Skip to content

Remove explicitly displayed chooser#1652

Merged
AndyScherzinger merged 1 commit into
nextcloud:masterfrom
rhari991:default-open-app
Oct 18, 2017
Merged

Remove explicitly displayed chooser#1652
AndyScherzinger merged 1 commit into
nextcloud:masterfrom
rhari991:default-open-app

Conversation

@rhari991

@rhari991 rhari991 commented Oct 10, 2017

Copy link
Copy Markdown

resolves #1415

@mario

mario commented Oct 10, 2017

Copy link
Copy Markdown
Contributor

👎

This is not a solution afaik. It doesn't allow you to set the default app.

Rejected with PullApprove

@rhari991

Copy link
Copy Markdown
Author

The currently used Intent.createChooser() option always displays the chooser option, even if an explicit opening app is selected. By removing this, Android should show a chooser with a default option if more than one app is available (at least it does for me).

s1

@mario

mario commented Oct 10, 2017

Copy link
Copy Markdown
Contributor

Ah, great! Sorry, is late.

Approving!

👍

Approved with PullApprove

@mario mario added this to the Nextcloud App 2.1.0 milestone Oct 10, 2017
@AndyScherzinger

AndyScherzinger commented Oct 10, 2017

Copy link
Copy Markdown
Member

👍 tested successfully!

@rhari991 I rebased and force pushed to your branch (!) to have it up-to-date with the Nextcloud master (newer app version).

This should be merged right after 2.0 release.

Approved with PullApprove

@tobiasKaminsky

Copy link
Copy Markdown
Member

@rhari991 as the feature request would affect your branch, maybe you want to add it here directly?
This would be awesome 🎉
#531 (comment)

#531 (comment)

Reference for inspiration: Automattic/simplenote-android:Simplenote/src/main/java/com/automattic/simplenote/ShareBottomSheetDialog.java@74466a2#L38

@AndyScherzinger
AndyScherzinger merged commit 7190a19 into nextcloud:master Oct 18, 2017
@AndyScherzinger

Copy link
Copy Markdown
Member

Awesome contribution @rhari991 🥇 merged to master 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to set a default PDF viewer with Android / Nextcloud

4 participants