fix(document-storage-provider): permission denial#17270
Open
alperozturk96 wants to merge 5 commits into
Open
Conversation
4 tasks
4 tasks
4 tasks
alperozturk96
force-pushed
the
fix/permission-denial
branch
from
bb5a286 to
8f8d5c5
Compare
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
fix/permission-denial
branch
from
8f8d5c5 to
e8d2393
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // asynchronous one. | ||
| Handler handler = new Handler(context.getMainLooper()); | ||
| try { | ||
| return ParcelFileDescriptor.open(file, accessMode, handler, error -> { |
| throw new FileNotFoundException("Failed to open document for writing " + ocFile.getFileName()); | ||
| } | ||
| } else { | ||
| return ParcelFileDescriptor.open(file, accessMode); |
|
APK file: https://github.com/nextcloud/android/actions/runs/29312354429/artifacts/8302671223 |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
| private fun ensureParentDirectory(target: File) { | ||
| val parent = target.parentFile ?: return | ||
|
|
||
| if (parent.exists() && !parent.isDirectory && !parent.delete()) { |
| private fun ensureParentDirectory(target: File) { | ||
| val parent = target.parentFile ?: return | ||
|
|
||
| if (parent.exists() && !parent.isDirectory && !parent.delete()) { |
| private fun ensureParentDirectory(target: File) { | ||
| val parent = target.parentFile ?: return | ||
|
|
||
| if (parent.exists() && !parent.isDirectory && !parent.delete()) { |
| Log_OC.e(TAG, "Unable to delete file blocking parent folder ${parent.absolutePath}") | ||
| } | ||
|
|
||
| if (!parent.exists() && !parent.mkdirs()) { |
| Log_OC.e(TAG, "Unable to delete file blocking parent folder ${parent.absolutePath}") | ||
| } | ||
|
|
||
| if (!parent.exists() && !parent.mkdirs()) { |
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17270-IT-master-09-21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #17258
caller identity needs to be cleared before trying to access
URI