New media detection

[mario]

Fixes #1447

Detects new media folder and notifies users about it.

[mario]

This is now ready for review folks! @AndyScherzinger @tobiasKaminsky

[mario]

Ummm so I checked lint report, but don't see what new warnings are?

[tobiasKaminsky]

You have to compare it with master.html which is in the same directory.
There is a lint tool to use current master as baseline, which then should only show the difference, but this does not work, so we have to compare it manually :/

[mario]

Looks ok now @tobiasKaminsky. Please test and review.

[AndyScherzinger]

I tested it installing OpenCamera and that didn't completely work for me.

• Works: Detection of new Folder 👍
• Failed: Directly configuring the new folder via the notification :(

The configuration is active while the pictures taken after don't get detected / uploaded.

[mario]

@AndyScherzinger could you look into NCContentObserverJob and see what syncedFolderProvider.countEnabledSyncedFolders() returns there?

[mario]

@AndyScherzinger @tobiasKaminsky fixed for real this time. Please rebase and test. Thanks!!!

[AndyScherzinger]

Can't test right now (time-wise) but did the rebase :)

[mario]

Anyone tested this?

[AndyScherzinger]

Imho now ready to review @tobiasKaminsky

I fixed:

• Directly configuring the new folder via the notification (now calculation the index in the list)
• Fixing the navigation issues described in New media detection #2406 (comment)
• Fixing the codacy issues that now came up due to the more restrictive checks due to the activation of pmd

[AndyScherzinger]

👍 approved from my side while I of course added / rewrote some code to fix the issues

so pinging @tobiasKaminsky and @ardevd for second review :)

[mario]

👍

cc @AndyScherzinger @tobiasKaminsky

[nextcloud-android-bot]

Lint

This	95 warnings
Master	95 warnings

FindBugs (new)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	166
Experimental Warnings	4
Internationalization Warnings	12
Malicious code vulnerability Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	159
Security Warnings	163
Dodgy code Warnings	207
Total	764

FindBugs (master)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	166
Experimental Warnings	4
Internationalization Warnings	12
Malicious code vulnerability Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	158
Security Warnings	163
Dodgy code Warnings	209
Total	765

[tobiasKaminsky]

👍

[jasonbayton]

Oh this is exciting! Thanks folks!