Skip to content

Correct menu highlighting#2773

Merged
AndyScherzinger merged 1 commit into
masterfrom
menuItemHighlighting
Jul 12, 2018
Merged

Correct menu highlighting#2773
AndyScherzinger merged 1 commit into
masterfrom
menuItemHighlighting

Conversation

@tobiasKaminsky

Copy link
Copy Markdown
Member

Now every combination (as far as I tested) should work, e.g.

  • on device
  • settings
  • on device

Please note that this does not work

  • favorites
  • settings
  • back
    -> it shows "all files" as also the "search" vanished.
    So the menu highlighting is correct, but the behaviour is not ;-)
    This is true for all other "search"-related menus.

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Lint

96 warnings

FindBugs (new)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings166
Experimental Warnings4
Internationalization Warnings12
Malicious code vulnerability Warnings9
Multithreaded correctness Warnings9
Performance Warnings158
Security Warnings163
Dodgy code Warnings209
Total765

FindBugs (master)

Warning TypeNumber
Bad practice Warnings35
Correctness Warnings166
Experimental Warnings4
Internationalization Warnings12
Malicious code vulnerability Warnings9
Multithreaded correctness Warnings9
Performance Warnings158
Security Warnings163
Dodgy code Warnings209
Total765

@codecov

codecov Bot commented Jun 29, 2018

Copy link
Copy Markdown

Codecov Report

Merging #2773 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #2773      +/-   ##
=========================================
+ Coverage    6.38%   6.38%   +<.01%     
=========================================
  Files         294     294              
  Lines       29563   29578      +15     
  Branches     4268    4269       +1     
=========================================
+ Hits         1888    1889       +1     
- Misses      27388   27402      +14     
  Partials      287     287
Impacted Files Coverage Δ
...m/owncloud/android/ui/activity/DrawerActivity.java 0% <0%> (ø) ⬆️
...oud/android/ui/activity/NotificationsActivity.java 0% <0%> (ø) ⬆️
...cloud/android/ui/activity/FileDisplayActivity.java 0% <0%> (ø) ⬆️
...loud/android/ui/activities/ActivitiesActivity.java 0% <0%> (ø) ⬆️
...oud/android/ui/activity/SyncedFoldersActivity.java 0% <0%> (ø) ⬆️
...ncloud/android/ui/activity/UploadListActivity.java 0% <0%> (ø) ⬆️
...cloud/android/ui/activity/ParticipateActivity.java 0% <0%> (ø) ⬆️
.../third_parties/daveKoeller/AlphanumComparator.java 82.75% <0%> (+1.14%) ⬆️

@AndyScherzinger

AndyScherzinger commented Jun 29, 2018

Copy link
Copy Markdown
Member

👍

Approved with PullApprove

AndyScherzinger added a commit that referenced this pull request Jul 4, 2018
Backport of #2773: correct menu highlighting
@mario

mario commented Jul 12, 2018

Copy link
Copy Markdown
Contributor

👍

Approved with PullApprove

@AndyScherzinger AndyScherzinger merged commit a0630d9 into master Jul 12, 2018
@AndyScherzinger AndyScherzinger deleted the menuItemHighlighting branch July 12, 2018 15:56
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.3.0 milestone Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants