Sync downloaded by tobiasKaminsky · Pull Request #2886 · nextcloud/android

tobiasKaminsky · 2018-08-14T07:44:33Z

Enhancement discussed in #2718

remove "keep available offline"
sync job
- only on wifi
- syncs all downloaded files
  - if conflict, just do nothing
  - deletes local files that are not on server any longer
when entering folder with outdated downloaded file, a red icon is shown on file

TODO

check handling after upgrade

mario · 2018-08-16T05:44:50Z

Would this support folders too?

tobiasKaminsky · 2018-08-16T05:51:05Z

Currently not as we do not have (yet) any possibility in UI to set "available offline" for folders.
It just enhances the current way.

We should discuss this properly and then implement it in a separate PR.
(keep in sync for folders is really close to two sync, or?)

AndyScherzinger · 2018-08-28T06:24:23Z

+            ocFolder.setEtagOnServer(updatedEtag);
+            storageManager.saveFile(ocFolder);
+        } catch (Exception e) {
+            Log_OC.e(TAG, "Failed to update etag on " + folder.getAbsolutePath());


should also log the exception, else you just know it failed but not for which reason

AndyScherzinger · 2018-08-28T06:28:12Z

👍 looks good code-wise and also worked for me for the browsing scenario. Didn't test the actual sync though.

I also agree that we should have the folder variant in a different PR and that would be close to a two way sync while for example deleting a file on the client asks you if you want to delete the file on the server too, so that is rather a one way sync server->client + syncing back changed files to the server not sure if we should handle created files since that would mean someone created a file within the clients directory structure.

AndyScherzinger · 2018-08-28T17:11:47Z

Imho this needs another DB version and a change routine to remove the fields from the database

tobiasKaminsky · 2018-08-30T12:40:21Z

change routine to remove the fields from the database

There is no way in sqlite to remove an existing column.
We can only ignore it and on new installation just do not create it…

mario · 2018-10-24T20:10:59Z

Looks decent, but why are there so many Glide changes in there?

tobiasKaminsky · 2018-10-25T08:02:15Z

This extends #2871.
I will update #2871 today.

tobiasKaminsky · 2018-12-12T06:58:18Z

@sehucke this is a very good feedback, thank you.

However I vote for merging this right now, as the meaning of icons stay the same and open up a new discussion how to improve this.

AndyScherzinger · 2018-12-12T07:24:55Z

However I vote for merging this right now, as the meaning of icons stay the same and open up a new discussion how to improve this.

I second that!

sehucke · 2018-12-12T07:38:35Z

👍

tobiasKaminsky · 2018-12-12T07:51:02Z

Rebased, should now compile again

mario · 2018-12-12T08:33:47Z

@tobiasKaminsky Codacy issues at least + build failed and I can then take a look.

tobiasKaminsky · 2018-12-12T12:27:59Z

Strange, only this PR is failing on tests, while e.g. #3350 is building fine: https://drone.nextcloud.com/nextcloud/android/7129

So I suggest, we ignore it ;-)

tobiasKaminsky · 2018-12-12T12:35:32Z

Hm. Seems indeed to be a valid problem:
Job intervall is set too low --> changed

AndyScherzinger · 2018-12-12T12:56:07Z

👍 works fine for me, I had

master + downloaded file (no wifi)
updated file on server
installed branch
file is marked red (since server changed, but no wifi)
activated wifi and waited for ~20 minutes
checked file -> makred green, up-to-date, no fetching server version, client already had the right file version

Thus merging

AndyScherzinger · 2018-12-12T12:56:39Z

@mario what do you think? Works fine for me (at least what I tested of course)

matsest · 2018-12-12T15:46:53Z

Would this allow for downloading/exporting a file from NC that is not affected by the sync? E.g. if I want to download/export a file from NC to my local Download folder and not Android/Media/com.nextcloud.android? At least for me, I don't have a Save to Device in the Share menu for a file in NC (as I have in Dropbox).

AndyScherzinger · 2018-12-12T16:13:29Z

@matsest No but you probably don't need that. SImply hit the share icon and choose an installed app, which allows for that e.g. Amaze File Manager :) (didn't test if this works though)

matsest · 2018-12-12T16:58:22Z

@AndyScherzinger Yes, that works with Amaze - have tested. However, it does not work with my default Files app (it's a crappy default Huawei app in EMUI), i.e. which is what "Save to Device" is in a range of other apps. I don't know much work there is to enable support for sharing to all these different CMFiles, Huawei Files app and other vendor specific default file apps. But it's a nice feature to be able to share across apps..

That's what I like about the sharing menu in Android - I probably don't need to be able to share a SMS to my Snapchat app (a crude example) and 15 other apps in the pop-up, but Android share menu allows for these interfaces between almost every app.

Specifically for a file sync app like NC I think it's a good idea that manual export/save to device should be possible without installing a third-party app for users - in addition to the offline/sync feature in this PR. That being said, I love Amaze and prefer it over default Files in EMUI, so I won't shed tears if this isn't taken into development ;)

Sorry if this was off topic for the PR (:

tobiasKaminsky · 2018-12-13T06:23:03Z

Specifically for a file sync app like NC I think it's a good idea that manual export/save to device

That is the problem: if you save a file to a folder outside NC it will never get updated. Therefore I am not a big fan of doing this.
If you have audio/video/images downloaded you can see them in gallery app / media player…
For further discussion please open up a new issue.

mario · 2018-12-13T22:26:35Z

Please make sure to drop the columns that we don't use anymore in the newest DB migration/transaction. Otherwise good.

tobiasKaminsky · 2018-12-14T08:07:16Z

#2886 (comment)

Andy: Imho this needs another DB version and a change routine to remove the fields from the database

#2886 (comment)

There is no way in sqlite to remove an existing column.
We can only ignore it and on new installation just do not create it…

:-D :-D

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

tobiasKaminsky · 2018-12-14T08:58:45Z

As this was previously based on glide branch, I forgot to remove the "update thumbnail" stuff.
So this is now back in, as this is required by the old thumbnail system.

nextcloud-android-bot · 2018-12-14T08:59:22Z

Lint

Type	master	PR
Warnings	83	83
Errors	0	0

FindBugs (new)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	159
Internationalization Warnings	15
Malicious code vulnerability Warnings	11
Multithreaded correctness Warnings	9
Performance Warnings	119
Security Warnings	66
Dodgy code Warnings	134
Total	548

FindBugs (master)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	159
Internationalization Warnings	15
Malicious code vulnerability Warnings	11
Multithreaded correctness Warnings	9
Performance Warnings	121
Security Warnings	66
Dodgy code Warnings	134
Total	550

tobiasKaminsky added the 3. to review label Aug 14, 2018

tobiasKaminsky force-pushed the syncDownloaded branch from c421e0b to 787dfaa Compare August 14, 2018 07:52

tobiasKaminsky mentioned this pull request Aug 15, 2018

scope of "available offline" in ... is incorrect #435

Closed

AndyScherzinger reviewed Aug 28, 2018

View reviewed changes

AndyScherzinger force-pushed the glide branch from e823701 to 97a2060 Compare August 28, 2018 08:10

AndyScherzinger mentioned this pull request Aug 28, 2018

Release 3.3.0 - Roadmap #2868

Closed

58 tasks

AndyScherzinger force-pushed the glide branch from 97a2060 to fef9db0 Compare August 28, 2018 16:34

AndyScherzinger force-pushed the syncDownloaded branch from 787dfaa to 43458a3 Compare August 28, 2018 16:59

tobiasKaminsky mentioned this pull request Sep 12, 2018

menu action naming schema for client/server related file actions #3023

Open

tobiasKaminsky force-pushed the glide branch from fef9db0 to 8ccaffb Compare September 24, 2018 12:28

nextcloud deleted a comment Sep 24, 2018

AndyScherzinger force-pushed the glide branch from 9531702 to faaa55b Compare September 24, 2018 17:08

tobiasKaminsky force-pushed the glide branch from ebad8bf to 64530cf Compare September 25, 2018 14:04

This was referenced Oct 10, 2018

Improve automatic synchronization process #4

Closed

[UX] Confusing terminology / icon: "Set as available offline" for files, refresh/sync icon for folders #208

Closed

AndyScherzinger mentioned this pull request Nov 1, 2018

File modified with excel not synchronized #3215

Open

AndyScherzinger mentioned this pull request Nov 21, 2018

Sync to server not working #3282

Closed

tobiasKaminsky force-pushed the glide branch from 6169601 to b80bba8 Compare December 3, 2018 14:44

tobiasKaminsky force-pushed the syncDownloaded branch from 7999299 to eb20d3b Compare December 3, 2018 15:54

tobiasKaminsky changed the base branch from glide to master December 3, 2018 15:54

tobiasKaminsky mentioned this pull request Dec 12, 2018

Improve sync UI/UX: status of file #3349

Open

tobiasKaminsky force-pushed the syncDownloaded branch from 04dd432 to dfccba5 Compare December 12, 2018 07:49

nextcloud deleted a comment Dec 13, 2018

Sync all downloaded files in background

6cf4998

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

tobiasKaminsky force-pushed the syncDownloaded branch from e41f1dc to 6cf4998 Compare December 14, 2018 08:54

nextcloud deleted a comment Dec 15, 2018

AndyScherzinger merged commit 7eba750 into master Dec 15, 2018

AndyScherzinger deleted the syncDownloaded branch December 15, 2018 11:20

AndyScherzinger added this to the Nextcloud App 3.5.0 milestone Dec 15, 2018

nextcloud-android-bot mentioned this pull request Jan 20, 2019

Syncing Pre-Existing Files Causes Re-upload and Download #3477

Closed

nextcloud-android-bot mentioned this pull request Feb 1, 2019

Enhance offline sync job #3542

Open

joshtrichards mentioned this pull request Oct 21, 2024

Differenciate between "Downloading" and "Make available offline" #3341

Closed

Uh oh!

Uh oh!

Conversation

tobiasKaminsky commented Aug 14, 2018 • edited by AndyScherzinger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mario commented Aug 16, 2018

Uh oh!

tobiasKaminsky commented Aug 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndyScherzinger Aug 28, 2018

Choose a reason for hiding this comment

Uh oh!

AndyScherzinger commented Aug 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndyScherzinger commented Aug 28, 2018

Uh oh!

tobiasKaminsky commented Aug 30, 2018

Uh oh!

mario commented Oct 24, 2018

Uh oh!

tobiasKaminsky commented Oct 25, 2018

Uh oh!

tobiasKaminsky commented Dec 12, 2018

Uh oh!

AndyScherzinger commented Dec 12, 2018

Uh oh!

sehucke commented Dec 12, 2018

Uh oh!

tobiasKaminsky commented Dec 12, 2018

Uh oh!

mario commented Dec 12, 2018

Uh oh!

tobiasKaminsky commented Dec 12, 2018

Uh oh!

tobiasKaminsky commented Dec 12, 2018

Uh oh!

AndyScherzinger commented Dec 12, 2018

Uh oh!

AndyScherzinger commented Dec 12, 2018

Uh oh!

matsest commented Dec 12, 2018

Uh oh!

AndyScherzinger commented Dec 12, 2018

Uh oh!

matsest commented Dec 12, 2018

Uh oh!

tobiasKaminsky commented Dec 13, 2018

Uh oh!

mario commented Dec 13, 2018

Uh oh!

tobiasKaminsky commented Dec 14, 2018

Uh oh!

tobiasKaminsky commented Dec 14, 2018

Uh oh!

nextcloud-android-bot commented Dec 14, 2018

Lint

FindBugs (new)

FindBugs (master)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tobiasKaminsky commented Aug 14, 2018 •

edited by AndyScherzinger

Loading

tobiasKaminsky commented Aug 16, 2018 •

edited

Loading

AndyScherzinger commented Aug 28, 2018 •

edited

Loading