Fix group share not working

[tobiasKaminsky]

Fix #3402

• fix wrong mapping from room to group
• take type into account when checking if already shared

To test:
share the same file / folder to:

• group
• user
• room/conversation

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

[nextcloud-android-bot]

Lint

Type	master	PR
Warnings	83	83
Errors	0	0

FindBugs (new)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	159
Internationalization Warnings	15
Malicious code vulnerability Warnings	12
Multithreaded correctness Warnings	9
Performance Warnings	119
Security Warnings	66
Dodgy code Warnings	135
Total	550

FindBugs (master)

Warning Type	Number
Bad practice Warnings	35
Correctness Warnings	159
Internationalization Warnings	15
Malicious code vulnerability Warnings	11
Multithreaded correctness Warnings	9
Performance Warnings	119
Security Warnings	66
Dodgy code Warnings	134
Total	548

[codecov]

Codecov Report

Merging #3440 into master will increase coverage by <.01%.
The diff coverage is 14.28%.

@@             Coverage Diff             @@
##             master   #3440      +/-   ##
===========================================
+ Coverage      6.13%   6.14%   +<.01%     
  Complexity        1       1              
===========================================
  Files           315     315              
  Lines         30523   30526       +3     
  Branches       4405    4405              
===========================================
+ Hits           1874    1875       +1     
- Misses        28367   28369       +2     
  Partials        282     282

Impacted Files	Coverage Δ	Complexity Δ
...cloud/android/ui/activity/FileDisplayActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...ndroid/providers/UsersAndGroupsSearchProvider.java	17.3% <50%> (+0.64%)	0 <0> (ø)	⬇️

[codecov]

Codecov Report

Merging #3440 into master will increase coverage by <.01%.
The diff coverage is 14.28%.

@@             Coverage Diff             @@
##             master   #3440      +/-   ##
===========================================
+ Coverage      6.13%   6.14%   +<.01%     
  Complexity        1       1              
===========================================
  Files           315     315              
  Lines         30523   30526       +3     
  Branches       4405    4405              
===========================================
+ Hits           1874    1875       +1     
- Misses        28367   28369       +2     
  Partials        282     282

Impacted Files	Coverage Δ	Complexity Δ
...cloud/android/ui/activity/FileDisplayActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...ndroid/providers/UsersAndGroupsSearchProvider.java	17.3% <50%> (+0.64%)	0 <0> (ø)	⬇️

[AndyScherzinger]

👍 looks good code wise 👍

[AndyScherzinger]

/backport to stable-3.4.x

[backportbot-nextcloud]

backport to stable-3.4.x in #3445