[stable-3.8] Remote wipe

[backportbot-nextcloud]

backport of #4455

[AndyScherzinger]

fine with me, while I strongly vote to get rid of the Literals in Conditional Statements (codacy) since such constructs are harder to read imho.

[tobiasKaminsky]

fine with me, while I strongly vote to get rid of the Literals in Conditional Statements (codacy) since such constructs are harder to read imho.

I'll fix this in master.

[AndyScherzinger]

I'll fix this in master.

👍

[tobiasKaminsky]

Also fixed it here… ;-)

[nextcloud-android-bot]

Lint

Type	stable-3.8	PR
Warnings	58	58
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	24
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	112
Security Warnings	46
Dodgy code Warnings	137
Total	413

SpotBugs (stable-3.8)

Warning Type	Number
Bad practice Warnings	24
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	110
Security Warnings	46
Dodgy code Warnings	137
Total	411

SpotBugs increased!

[codecov]

Codecov Report

Merging #4457 into stable-3.8 will increase coverage by <.01%.
The diff coverage is 6%.

@@               Coverage Diff                @@
##             stable-3.8    #4457      +/-   ##
================================================
+ Coverage         16.99%   16.99%   +<.01%     
  Complexity            1        1              
================================================
  Files               359      360       +1     
  Lines             31932    31971      +39     
  Branches           4501     4508       +7     
================================================
+ Hits               5426     5433       +7     
- Misses            25600    25636      +36     
+ Partials            906      902       -4

Impacted Files	Coverage Δ	Complexity Δ
...oud/android/ui/asynctasks/CheckRemoteWipeTask.java	0% <0%> (ø)	0 <0> (?)
...com/owncloud/android/ui/activity/FileActivity.java	26.41% <0%> (-0.41%)	0 <0> (ø)
...m/owncloud/android/ui/activity/DrawerActivity.java	44.46% <0%> (-0.07%)	0 <0> (ø)
...owncloud/android/ui/activity/UserInfoActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...loud/android/datamodel/FileDataStorageManager.java	36.4% <0%> (ø)	0 <0> (ø)	⬇️
...a/com/owncloud/android/jobs/AccountRemovalJob.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...wncloud/android/providers/FileContentProvider.java	22.03% <54.54%> (-0.19%)	0 <0> (ø)
.../java/com/owncloud/android/utils/DisplayUtils.java	23.62% <0%> (-1.27%)	0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java	82.14% <0%> (ø)	0% <0%> (ø)	⬇️
... and 4 more

[codecov]

Codecov Report

Merging #4457 into stable-3.8 will decrease coverage by 0.01%.
The diff coverage is 6%.

@@               Coverage Diff                @@
##             stable-3.8    #4457      +/-   ##
================================================
- Coverage         16.99%   16.98%   -0.02%     
  Complexity            1        1              
================================================
  Files               359      360       +1     
  Lines             31932    31971      +39     
  Branches           4501     4508       +7     
================================================
+ Hits               5426     5429       +3     
- Misses            25600    25639      +39     
+ Partials            906      903       -3

Impacted Files	Coverage Δ	Complexity Δ
...oud/android/ui/asynctasks/CheckRemoteWipeTask.java	0% <0%> (ø)	0 <0> (?)
...com/owncloud/android/ui/activity/FileActivity.java	26.41% <0%> (-0.41%)	0 <0> (ø)
...m/owncloud/android/ui/activity/DrawerActivity.java	44.46% <0%> (-0.07%)	0 <0> (ø)
...owncloud/android/ui/activity/UserInfoActivity.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...loud/android/datamodel/FileDataStorageManager.java	36.4% <0%> (ø)	0 <0> (ø)	⬇️
...a/com/owncloud/android/jobs/AccountRemovalJob.java	0% <0%> (ø)	0 <0> (ø)	⬇️
...wncloud/android/providers/FileContentProvider.java	22.03% <54.54%> (-0.19%)	0 <0> (ø)
.../java/com/owncloud/android/utils/DisplayUtils.java	23.62% <0%> (-1.27%)	0% <0%> (ø)
...loud/android/datamodel/ThumbnailsCacheManager.java	35.03% <0%> (-0.55%)	0% <0%> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java	82.14% <0%> (ø)	0% <0%> (ø)	⬇️
... and 5 more

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/10842.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Lint

Type	stable-3.8	PR
Warnings	58	58
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	24
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	110
Security Warnings	46
Dodgy code Warnings	137
Total	411

SpotBugs (stable-3.8)

Warning Type	Number
Bad practice Warnings	24
Correctness Warnings	69
Internationalization Warnings	12
Malicious code vulnerability Warnings	4
Multithreaded correctness Warnings	9
Performance Warnings	110
Security Warnings	46
Dodgy code Warnings	137
Total	411