Skip to content

Fix crash when adding new ODS file #5065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobiasKaminsky merged 1 commit into from
Jan 6, 2020
Merged

Fix crash when adding new ODS file #5065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/com/owncloud/android/ui/dialog/ChooseTemplateDialogFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,9 +235,9 @@ protected String doInBackground(Void... voids) {

@Override
protected void onPostExecute(String url) {
ChooseTemplateDialogFragment fragment = chooseTemplateDialogFragmentWeakReference.get();
final ChooseTemplateDialogFragment fragment = chooseTemplateDialogFragmentWeakReference.get();

if (fragment != null) {
if (fragment != null && fragment.isAdded()) {
if (url.isEmpty()) {
DisplayUtils.showSnackMessage(fragment.listView, "Error creating file from template");
} else {
Expand All @@ -247,7 +247,6 @@ protected void onPostExecute(String url) {
collaboraWebViewIntent.putExtra(ExternalSiteWebView.EXTRA_SHOW_SIDEBAR, false);
collaboraWebViewIntent.putExtra(ExternalSiteWebView.EXTRA_TEMPLATE, Parcels.wrap(template));
fragment.startActivity(collaboraWebViewIntent);

fragment.dismiss();
}
} else {
Expand Down