Skip to content

[stable-3.11] Use UTF8 PostMethod everywhere#5621

Merged
AndyScherzinger merged 1 commit into
stable-3.11from
backport/5614/stable-3.11
Mar 11, 2020
Merged

[stable-3.11] Use UTF8 PostMethod everywhere#5621
AndyScherzinger merged 1 commit into
stable-3.11from
backport/5614/stable-3.11

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

backport of #5614

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Lint

Typestable-3.11PR
Warnings7676
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings77
Security Warnings45
Dodgy code Warnings137
Total382

SpotBugs (stable-3.11)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings77
Security Warnings45
Dodgy code Warnings137
Total382

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Lint

Typestable-3.11PR
Warnings7676
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings77
Security Warnings45
Dodgy code Warnings137
Total382

SpotBugs (stable-3.11)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings77
Security Warnings45
Dodgy code Warnings137
Total382

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13014.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Lint

Typestable-3.11PR
Warnings7676
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings77
Security Warnings45
Dodgy code Warnings137
Total382

SpotBugs (stable-3.11)

Warning TypeNumber
Bad practice Warnings26
Correctness Warnings70
Internationalization Warnings13
Malicious code vulnerability Warnings5
Multithreaded correctness Warnings9
Performance Warnings77
Security Warnings45
Dodgy code Warnings137
Total382

@codecov

codecov Bot commented Mar 11, 2020

Copy link
Copy Markdown

Codecov Report

Merging #5621 into stable-3.11 will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@                Coverage Diff                @@
##             stable-3.11    #5621      +/-   ##
=================================================
+ Coverage          24.25%   24.30%   +0.05%     
  Complexity             3        3              
=================================================
  Files                398      398              
  Lines              33628    33628              
  Branches            4718     4718              
=================================================
+ Hits                8157     8174      +17     
+ Misses             24187    24162      -25     
- Partials            1284     1292       +8     
Impacted Files Coverage Δ Complexity Δ
...android/files/CreateFileFromTemplateOperation.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ncloud/android/files/StreamMediaFileOperation.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ava/com/owncloud/android/jobs/NotificationJob.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../operations/RichDocumentsCreateAssetOperation.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../android/operations/RichDocumentsUrlOperation.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...d/ui/asynctasks/NotificationExecuteActionTask.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../third_parties/daveKoeller/AlphanumComparator.java 80.95% <0.00%> (-2.39%) 0.00% <0.00%> (ø%)
...com/owncloud/android/ui/activity/FileActivity.java 26.79% <0.00%> (ø) 0.00% <0.00%> (ø%)
...cloud/android/ui/preview/PreviewImageActivity.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...cloud/android/ui/preview/PreviewVideoActivity.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 7 more

@AndyScherzinger AndyScherzinger merged commit 07ed6ae into stable-3.11 Mar 11, 2020
@delete-merged-branch delete-merged-branch Bot deleted the backport/5614/stable-3.11 branch March 11, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants