Skip to content

HotFix master branch: Set fixed lib version#62

Merged
tobiasKaminsky merged 1 commit into
masterfrom
jitpackFix
Jun 24, 2016
Merged

HotFix master branch: Set fixed lib version#62
tobiasKaminsky merged 1 commit into
masterfrom
jitpackFix

Conversation

@AndyScherzinger

Copy link
Copy Markdown
Member

For some reason jitpack is not refreshing the snapshot build so the branch won't build thus I created a lib release 1.0.1 and set the dependency to 1.0.1 instead of -SNAPSHOT

ATM This is necessary in order to get master to compile again. Sorry for any inconvenience :(

@AndyScherzinger

Copy link
Copy Markdown
Member Author

FYI the display name change in the lib simply adds the possibility to retrieve the full name, we haven't utilized this yet but I will asap for the drawer implementation but that isn't a blocking issue so we can still release the app whenever we think it is ready and can ship full name display any time later :)

@przybylski

przybylski commented Jun 23, 2016

Copy link
Copy Markdown
Member

👍 👍 we always should depend on stable version not repos snapshot

@AndyScherzinger

Copy link
Copy Markdown
Member Author

That's true! Absolutely 👍

@tobiasKaminsky

Copy link
Copy Markdown
Member

👍
We should keep the version mostly the same!

@tobiasKaminsky
tobiasKaminsky merged commit 24d238b into master Jun 24, 2016
@tobiasKaminsky
tobiasKaminsky deleted the jitpackFix branch June 24, 2016 13:42
@AndyScherzinger

Copy link
Copy Markdown
Member Author

@tobiasKaminsky why keep it mostly the same? We could create new versions for new features which would only be used on a feature branch and push the new version/dependency with the feature PR to master. Not sure I got your point :S

@tobiasKaminsky

Copy link
Copy Markdown
Member

Yeah, I think I was confused. Please forget my idea ;)

@Queeq Queeq mentioned this pull request Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants