DocumentsStorageProvider: open thumbnail directly

[tobiasKaminsky]

fix #6884

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

• Tests written, or not not needed

[nextcloud-android-bot]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15727.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[nextcloud-android-bot]

Codacy

394

Lint

Type	master	PR
Warnings	81	81
Errors	0	0

SpotBugs (new)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	54
Internationalization Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	72
Security Warnings	44
Dodgy code Warnings	105
Total	320

SpotBugs (master)

Warning Type	Number
Bad practice Warnings	27
Correctness Warnings	54
Internationalization Warnings	9
Multithreaded correctness Warnings	9
Performance Warnings	72
Security Warnings	44
Dodgy code Warnings	105
Total	320

[codecov]

Codecov Report

Merging #6886 into master will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #6886      +/-   ##
============================================
+ Coverage     28.57%   28.60%   +0.02%     
  Complexity        5        5              
============================================
  Files           427      427              
  Lines         34199    34197       -2     
  Branches       4729     4729              
============================================
+ Hits           9773     9782       +9     
+ Misses        22965    22956       -9     
+ Partials       1461     1459       -2     

Impacted Files	Coverage Δ	Complexity Δ
...droid/providers/DiskLruImageCacheFileProvider.java	9.30% <0.00%> (ø)	0.00 <0.00> (ø)
...ud/android/providers/DocumentsStorageProvider.java	50.14% <0.00%> (+0.28%)	0.00 <0.00> (ø)
...ain/java/com/owncloud/android/db/UploadResult.java	39.74% <0.00%> (-2.57%)	0.00% <0.00%> (ø%)
...cloud/android/datamodel/UploadsStorageManager.java	66.41% <0.00%> (-2.27%)	0.00% <0.00%> (ø%)
.../java/com/owncloud/android/utils/DisplayUtils.java	30.20% <0.00%> (-2.05%)	0.00% <0.00%> (ø%)
.../third_parties/daveKoeller/AlphanumComparator.java	82.14% <0.00%> (-1.20%)	0.00% <0.00%> (ø%)
...loud/android/datamodel/ThumbnailsCacheManager.java	38.32% <0.00%> (-0.73%)	0.00% <0.00%> (ø%)
...loud/android/ui/fragment/ExtendedListFragment.java	51.40% <0.00%> (-0.32%)	0.00% <0.00%> (ø%)
...com/owncloud/android/ui/activity/FileActivity.java	21.27% <0.00%> (-0.28%)	0.00% <0.00%> (ø%)
.../owncloud/android/files/services/FileUploader.java	48.96% <0.00%> (-0.21%)	0.00% <0.00%> (ø%)
... and 8 more

[grote]

I don't know anything about the DiskLruImageCacheFileProvider, but the rest of the changes look good to me.

[jmue]

Tested successfully, Exception is gone. LGTM