Ensure that upload notification gets cancelled#7050
Conversation
Normally, the notification gets cancelled when the service is destroyed. But that does not always happen in practice, so we also cancel it after every result. Signed-off-by: Torsten Grote <t@grobox.de>
9ec2422 to
931aac7
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16051.apk |
|
master-light-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16051-Screenshot-master-light-blue |
|
stable-light-blue-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16051-Screenshot-stable-light-blue |
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16051-IT-stable |
CodacyLint
SpotBugs (new)
SpotBugs (master)
|
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16051-IT-master |
|
@tobiasKaminsky after using this branch, I haven't noticed any stuck notifications form FileUploader anymore. |
Ensure that upload notification gets cancelled Signed-off-by: thelittlefireman <thelittlefireman@users.noreply.github.com>
4 participants
This is a follow up to #6997.
Normally, the notification gets cancelled when the service is destroyed. But that does not always happen in practice, so we also cancel it after every result.