Skip to content

Add dashboard category#737

Merged
MorrisJobke merged 1 commit into
masterfrom
enh/noid/dashboard
Aug 5, 2020
Merged

Add dashboard category#737
MorrisJobke merged 1 commit into
masterfrom
enh/noid/dashboard

Conversation

@juliusknorr

@juliusknorr juliusknorr commented Aug 4, 2020

Copy link
Copy Markdown
Member

For nextcloud/server#20930

Once merged:

  • Update resources/app-info.xsd in server as well nextcloud/server@b88b86e
  • Add app store category to supporting apps info.xml

{% trans "Customization" %}
{% trans "Themes, layout and UX change apps" %}
{% trans "Dashboard" %}
{% trans "Apps for Nextcloud Dashboard" %}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

"fields": {
"language_code": "en",
"name": "Dashboard",
"description": "Apps for Nextcloud Dashboard",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this category is for apps that "include" a dashboard widget but that are potentially not specialized in that area. What about changing this to
Apps including Nextcloud Dashboard widgets ?

@coveralls

coveralls commented Aug 4, 2020

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 94.386% when pulling 6e675c0 on enh/noid/dashboard into c4d3206 on master.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr dismissed julien-nc’s stale review August 4, 2020 14:24

Good point. Fixed.

@MorrisJobke MorrisJobke merged commit 1d9c9cd into master Aug 5, 2020
@delete-merged-branch delete-merged-branch Bot deleted the enh/noid/dashboard branch August 5, 2020 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants