Fixed #1893

[der-daniel]

Description

The URI to the DAV resource has not been url-decoded.

Fixes #1893

[der-daniel]

I tried to get this sign off thing into my last commit and force pushed it.

Is there another way of doing this? AFAIK I can only edit mt commit message by force pushing it once it is in the remote origin.

[SuperSandro2000]

You did the correct thing but the mail is not matching according to DCO. Take a look here https://github.com/nextcloud/calendar/pull/1985/checks?check_run_id=438913803 .

To get there click on the checks tab at the top, expand DCO and click on the entry.
Would wish that the "Details" links would go there.

[der-daniel]

Fixed it. This sign off was new to me. 👍

[georgehrke]

I'm sorry, but this is not a real fix from my pov, rather a hot fix.

The problem is that the contents of <d:path> inside the principal-property-search is wrongly encoded. Just open the developer console and inspect the network request when searching for users / groups.

[georgehrke]

Reopening as of nextcloud/server#17610 (comment)

[georgehrke]

This breaks not showing groups already shared with.

[georgehrke]

If you change line 150 to the following, it works as expected:

				if (hiddenPrincipals.includes(decodeURI(result.principalScheme))) {

[georgehrke]

@der-daniel Are you gonna fix line 150 or should I? :)

[der-daniel]

Just pushed it. Thanks for this finding!

[georgehrke]

Thank you very much, it works as expected now 👍

[georgehrke]

My current plan is to have Calendar 2.0.2 by the end of next week.