Timezone simple event#883
Closed
Peterede wants to merge 4 commits into
Closed
Conversation
Member
|
@Peterede Can you adapt the tests too ? |
georgehrke
requested changes
Aug 15, 2018
georgehrke
left a comment
georgehrke
left a comment
Member
There was a problem hiding this comment.
- Please fix the failing tests
- please rename
timezonetotzidto keep it consistent (and standard conform 😉)
Member
Author
|
I changed timezone to tzid. When I run the tests using karma start tests/js/config/karma.js I get a lot of errors about 'moment is not defined' even without my changes, could this be a problem with the setup of my test environment? |
Author
|
I was able to get the tests to run and it returned OK (53 tests, 325 assertions) |
Member
|
This has been implemented in calendar-js. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added timezone to attendee params in SimpleEvent to store and retrieve the timezone for an attendee.