fix(permission): get permissions for user from inherited when not direct member#2572
Merged
Merged
Conversation
|
Just gave this a try, can confirm this fixes nextcloud/contacts#5418. |
artonge
approved these changes
Jul 2, 2026
cristianscheid
force-pushed
the
fix/noid/permission-user-member
branch
from
July 2, 2026 14:19
8cad841 to
bedb6bb
Compare
…ect member Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
cristianscheid
force-pushed
the
fix/noid/permission-user-member
branch
from
July 2, 2026 14:29
bedb6bb to
2f114e4
Compare
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable32 |
This was referenced Jul 2, 2026
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/Service/PermissionService::userMustBeMember()was not taking into account the permission level from the group/circle through which the user has access to this circlelib/Service/PermissionService::userMustBeMember()to consider inherited permissions when user is no direct memberChecklist
3. to review, feature component)stable32)AI (if applicable)