Skip to content

fix(permission): get permissions for user from inherited when not direct member#2572

Merged
cristianscheid merged 1 commit into
masterfrom
fix/noid/permission-user-member
Jul 2, 2026
Merged

fix(permission): get permissions for user from inherited when not direct member#2572
cristianscheid merged 1 commit into
masterfrom
fix/noid/permission-user-member

Conversation

@cristianscheid

@cristianscheid cristianscheid commented Jul 2, 2026

Copy link
Copy Markdown
Member

Summary

  • as mentioned on issue linked above, PR adjust local controller to better handle permission checks #2522 introduced a regression
  • main point brought up on the issue is that when a user is a member of a circle via a group, user has no longer access to it's member list and other resources
  • what was causing this is that lib/Service/PermissionService::userMustBeMember() was not taking into account the permission level from the group/circle through which the user has access to this circle
  • this PR adjusts lib/Service/PermissionService::userMustBeMember() to consider inherited permissions when user is no direct member

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@cristianscheid cristianscheid self-assigned this Jul 2, 2026
@cristianscheid cristianscheid changed the title fix(permission): get permissions for user from inherited when not dir… fix(permission): get permissions for user from inherited when not direct member Jul 2, 2026
@jonas2515

Copy link
Copy Markdown

Just gave this a try, can confirm this fixes nextcloud/contacts#5418.

@cristianscheid
cristianscheid force-pushed the fix/noid/permission-user-member branch from 8cad841 to bedb6bb Compare July 2, 2026 14:19
…ect member

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid
cristianscheid force-pushed the fix/noid/permission-user-member branch from bedb6bb to 2f114e4 Compare July 2, 2026 14:29
@cristianscheid

Copy link
Copy Markdown
Member Author

/backport to stable34

@cristianscheid

Copy link
Copy Markdown
Member Author

/backport to stable33

@cristianscheid

Copy link
Copy Markdown
Member Author

/backport to stable31

@cristianscheid

Copy link
Copy Markdown
Member Author

/backport to stable32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'There was an error fetching the member list'

3 participants