Improve design of new address book name input#180
Closed
jancborchardt wants to merge 1 commit into
Closed
Conversation
jancborchardt
added
3. to review
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
force-pushed
the
settings-confirm
branch
from
4923012 to
ca0ead8
Compare
Codecov Report
@@ Coverage Diff @@
## master #180 +/- ##
=======================================
Coverage 16.42% 16.42%
=======================================
Files 50 50
Lines 1023 1023
=======================================
Hits 168 168
Misses 855 855
Continue to review full report at Codecov.
|
Member
|
Difference screenshot please? :p |
Member
|
Merge of #101 broke this. Additionally the PR fixed some aspects of the submit button. @jancborchardt would you mind revisit this? I saw that it changed the opacity on hover, would you mind adding this also for the options in the popover menu? |
irgendwie
added
2. developing
Member
Author
|
Ok, no change needed after #101. :) The hover changes are better done in core. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review @nextcloud/contacts @nextcloud/designers :)
