Better readability on bright header background colors, fix #90#338
Merged
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
added
3. to review
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
=======================================
Coverage 14.17% 14.17%
=======================================
Files 55 55
Lines 1263 1263
=======================================
Hits 179 179
Misses 1084 1084Continue to review full report at Codecov.
|
skjnldsv
approved these changes
Sep 20, 2017
skjnldsv
left a comment
skjnldsv
left a comment
Member
There was a problem hiding this comment.
Wow, didn't thought it would have that much impact on yellow! Well done, you were perfectly right!! 😉👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before / after:
Fix #90 by adding a slight text-shadow. This separates the text from the background ever so slightly and increases the readability on bright colors greatly.
Please review @nextcloud/contacts @nextcloud/designers @axelsimon