Add quick actions for contacts

[GretaD]

fixes #3365

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.24% 🎉

Comparison is base (dc8bf5a) 1.82% compared to head (8bc1765) 2.07%.
Report is 5 commits behind head on main.

❗ Current head 8bc1765 differs from pull request most recent head 30b1360. Consider uploading reports for the commit 30b1360 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##              main   #3401      +/-   ##
==========================================
+ Coverage     1.82%   2.07%   +0.24%     
==========================================
  Files          112      89      -23     
  Lines         6072    5356     -716     
  Branches      1480    1499      +19     
==========================================
  Hits           111     111              
+ Misses        5845    5127     -718     
- Partials       116     118       +2     

Files Changed	Coverage Δ
src/components/ContactDetails.vue	0.00% <0.00%> (ø)
src/models/contact.js	12.02% <0.00%> (-0.41%)	⬇️
src/models/rfcProps.js	45.45% <ø> (ø)
src/services/isTalkEnabled.js	0.00% <0.00%> (ø)

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ChristophWurst]

is 15 arbitrary or did the talk links not work before that?

[GretaD]

no its not arbitrary, i quickly checked releases and i didnt see backports on 14th i think, but i will ask Marco or Joas for a clear answer

[ChristophWurst]

the feature was added with nextcloud/spreed#300, so v2

[ChristophWurst]

• BUG: [Vue warn]: Error in render: "TypeError: this.phoneNumberProperty.getFirstValue is not a function" for contacts with no phone number

[ChristophWurst]

• BUG: Quick actions are not aligned with the rest of the page

Edit: they are placed properly for Contacts with Detailed name, not for those without

[GretaD]

• BUG: [Vue warn]: Error in render: "TypeError: this.phoneNumberProperty.getFirstValue is not a function" for contacts with no phone number

i cannot see this in my logs. I see that the icons dont have background color, are you sure you have the latest changes?

[JohannesGGE]

I added a fixup with the access logic to the profileURL

[GretaD]

I added a fixup with the access logic to the profileURL

thank you Johannes, i will have a look asap

[st3iny]

I tested it briefly. Design still needs some work as the buttons are aligned incorrectly.

[st3iny]

Follow up:

• ### Empty email addresses are not filtered

Note: The contact has empty email address fields. This is not common in practice but still looks weird.

• ### Quick actions take a lot of horizontal space and don't wrap

Might not be related and can be fixed later.

• ### Clicking the talk button does nothing Fixed

There is no error in the console.

[st3iny]

Tested and works. The design needs some attention in a followup.