Skip to content

Conversation

@nickvergessen
Copy link
Member

  • Best reviewed commit by commit
  • ⚠️ Please note "ci(action)!: Remove action that builds each push" and judge if okay, otherwise that file needs fixing, but I felt it is over the top

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84358 was 83517 (+1%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@nickvergessen
Copy link
Member Author

I can fix psalm and the current cypress step

But not a lot ideas about Node CI

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84288 was 83517 (+0.92%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84365 was 83517 (+1.01%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84288 was 83517 (+0.92%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@github-actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84289 was 83517 (+0.92%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@blizzz blizzz merged commit 906c183 into main Jan 22, 2026
42 checks passed
@blizzz blizzz deleted the ci/noid/actions branch January 22, 2026 20:43
@blizzz
Copy link
Member

blizzz commented Jan 22, 2026

/backport to stable33

@blizzz
Copy link
Member

blizzz commented Jan 22, 2026

/backport to stable32

@blizzz
Copy link
Member

blizzz commented Jan 22, 2026

/backport to stable31

@blizzz
Copy link
Member

blizzz commented Jan 22, 2026

/backport to stable32

2 similar comments
@nickvergessen
Copy link
Member Author

/backport to stable32

@blizzz
Copy link
Member

blizzz commented Jan 22, 2026

/backport to stable32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants