fix: set REDIS_HOST_PASSWORD to empty string when not set - #1232
Merged
Conversation
Contributor
|
Thanks! |
This was referenced Nov 7, 2020
Closed
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Nov 7, 2020
Changes: - https///github.com/nextcloud/docker/commit/65634ab: Runs update.sh - https///github.com/nextcloud/docker/commit/b8cc63f: fix: empty redis password must be string (https///github.com/nextcloud/docker/pull/1232) - https///github.com/nextcloud/docker/commit/6fd2227: Add GitHub CI badge (https///github.com/nextcloud/docker/pull/1301) - https///github.com/nextcloud/docker/commit/4efaf22: Merge pull request https///github.com/nextcloud/docker/pull/1294 from J0WI/rm17 - https///github.com/nextcloud/docker/commit/83503a4: Remove 17.0
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Nov 13, 2020
Changes: - https///github.com/nextcloud/docker/commit/2b75fba: Runs update.sh - https///github.com/nextcloud/docker/commit/65634ab: Runs update.sh - https///github.com/nextcloud/docker/commit/b8cc63f: fix: empty redis password must be string (https///github.com/nextcloud/docker/pull/1232) - https///github.com/nextcloud/docker/commit/6fd2227: Add GitHub CI badge (https///github.com/nextcloud/docker/pull/1301) - https///github.com/nextcloud/docker/commit/4efaf22: Merge pull request https///github.com/nextcloud/docker/pull/1294 from J0WI/rm17 - https///github.com/nextcloud/docker/commit/83503a4: Remove 17.0
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Nov 17, 2020
Changes: - https///github.com/nextcloud/docker/commit/58419d4: Runs update.sh - https///github.com/nextcloud/docker/commit/2b75fba: Runs update.sh - https///github.com/nextcloud/docker/commit/65634ab: Runs update.sh - https///github.com/nextcloud/docker/commit/b8cc63f: fix: empty redis password must be string (https///github.com/nextcloud/docker/pull/1232) - https///github.com/nextcloud/docker/commit/6fd2227: Add GitHub CI badge (https///github.com/nextcloud/docker/pull/1301) - https///github.com/nextcloud/docker/commit/4efaf22: Merge pull request https///github.com/nextcloud/docker/pull/1294 from J0WI/rm17 - https///github.com/nextcloud/docker/commit/83503a4: Remove 17.0
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Nov 19, 2020
Changes: - https///github.com/nextcloud/docker/commit/62398b5: Runs update.sh - https///github.com/nextcloud/docker/commit/58419d4: Runs update.sh - https///github.com/nextcloud/docker/commit/2b75fba: Runs update.sh - https///github.com/nextcloud/docker/commit/65634ab: Runs update.sh - https///github.com/nextcloud/docker/commit/b8cc63f: fix: empty redis password must be string (https///github.com/nextcloud/docker/pull/1232) - https///github.com/nextcloud/docker/commit/6fd2227: Add GitHub CI badge (https///github.com/nextcloud/docker/pull/1301) - https///github.com/nextcloud/docker/commit/4efaf22: Merge pull request https///github.com/nextcloud/docker/pull/1294 from J0WI/rm17 - https///github.com/nextcloud/docker/commit/83503a4: Remove 17.0
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Nov 19, 2020
Changes: - https///github.com/nextcloud/docker/commit/c292b9b: Update stable channel to 19.0.5 - https///github.com/nextcloud/docker/commit/62398b5: Runs update.sh - https///github.com/nextcloud/docker/commit/58419d4: Runs update.sh - https///github.com/nextcloud/docker/commit/2b75fba: Runs update.sh - https///github.com/nextcloud/docker/commit/65634ab: Runs update.sh - https///github.com/nextcloud/docker/commit/b8cc63f: fix: empty redis password must be string (https///github.com/nextcloud/docker/pull/1232) - https///github.com/nextcloud/docker/commit/6fd2227: Add GitHub CI badge (https///github.com/nextcloud/docker/pull/1301) - https///github.com/nextcloud/docker/commit/4efaf22: Merge pull request https///github.com/nextcloud/docker/pull/1294 from J0WI/rm17 - https///github.com/nextcloud/docker/commit/83503a4: Remove 17.0
cuppett
added a commit
to cuppett/nextcloud-openshift-s2i
that referenced
this pull request
Dec 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not setting
REDIS_HOST_PASSWORDcurrently leads to a "RedisException: ERR AUTH called without any password configured for the default user." error. this seems to happen becausegetenvreturnsfalse, but the nextcloud server only checksissetand for an empty string (see here). casting to a string should hopefully fix this???fixes #1179