Skip to content

Do not set retry flag on ForbiddenException#163

Merged
blizzz merged 1 commit into
masterfrom
bugfix/noid/retry-forbidden
Sep 3, 2020
Merged

Do not set retry flag on ForbiddenException#163
blizzz merged 1 commit into
masterfrom
bugfix/noid/retry-forbidden

Conversation

@juliusknorr

@juliusknorr juliusknorr commented Sep 3, 2020

Copy link
Copy Markdown
Member

For nextcloud/server#22556

From owncloud/core#20494 i assumed that the retry was introduced to indicate that clients should try to sync again at a later point, so I think it makes sense to not set this for files_accesscontrol thrown ForbiddenExceptions.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@nickvergessen

Copy link
Copy Markdown
Member

Well there is a request time option on access control, or your IP could change. But I tend to agree it makes no sense in most cases.

@blizzz

blizzz commented Sep 3, 2020

Copy link
Copy Markdown
Member

It sounds to be a corner case in several directions, i.e. already uploading into restricted directories. If avoiding the chance to have stray part files is more important than to keep the state in those other conditions, then yes, sure. Will take away a bit of conformability with those edge cases. I arrive at the same conclusion as @nickvergessen.

@blizzz blizzz merged commit 44a7a5b into master Sep 3, 2020
@delete-merged-branch delete-merged-branch Bot deleted the bugfix/noid/retry-forbidden branch September 3, 2020 10:57
@juliusknorr

Copy link
Copy Markdown
Member Author

/backport to stable19

@juliusknorr

Copy link
Copy Markdown
Member Author

/backport to stable18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants