Skip to content

perf: Avoir calling Server::get for each share mounts#1113

Merged
AndyScherzinger merged 3 commits into
mainfrom
carl/perf-storagewrapper
Jun 22, 2026
Merged

perf: Avoir calling Server::get for each share mounts#1113
AndyScherzinger merged 3 commits into
mainfrom
carl/perf-storagewrapper

Conversation

@CarlSchwan

@CarlSchwan CarlSchwan commented Jun 19, 2026

Copy link
Copy Markdown
Member

This take a while when an user has multiple thousands shares

See apps/files_trashbin/lib/Storage.php::setupStorage for some similar perf hack

image

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

This take a while when an user has multiple thousands shares

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan CarlSchwan force-pushed the carl/perf-storagewrapper branch from 120fdb9 to f91182e Compare June 19, 2026 10:03

@salmart-dev salmart-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Altahrim

Copy link
Copy Markdown

Psalm related to change of version?

@CarlSchwan

Copy link
Copy Markdown
Member Author

Psalm related to change of version?

it's me trying to fix the CI, the issue is already present in master

@CarlSchwan CarlSchwan force-pushed the carl/perf-storagewrapper branch from aaaf384 to fb0d668 Compare June 19, 2026 15:07
And fix the issues

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan CarlSchwan force-pushed the carl/perf-storagewrapper branch from fb0d668 to 2258020 Compare June 19, 2026 15:09
PHP 8.2 is no longer supported by master

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@AndyScherzinger AndyScherzinger merged commit 420a8b7 into main Jun 22, 2026
46 of 47 checks passed
@AndyScherzinger AndyScherzinger deleted the carl/perf-storagewrapper branch June 22, 2026 10:01
@CarlSchwan

Copy link
Copy Markdown
Member Author

/backport f91182e to stable34

@CarlSchwan

Copy link
Copy Markdown
Member Author

/backport f91182e to stable33

@CarlSchwan

Copy link
Copy Markdown
Member Author

/backport f91182e to stable32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants