Skip to content

Fix pdfviewer design #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
szaimen merged 1 commit into from
Jul 13, 2021
Merged

Fix pdfviewer design #443

szaimen merged 1 commit into from
Jul 13, 2021

Conversation

@szaimen
Copy link
Collaborator

@szaimen szaimen commented Jul 8, 2021 •
edited
Loading

Fix #279
Fix #238

Desktop

Before After After with sidebar open
image image image

Mobile

Before Before After
image image image

Signed-off-by: szaimen szaimen@e.mail.de

@szaimen szaimen added this to the Nextcloud 23 milestone Jul 8, 2021
@szaimen szaimen force-pushed the enh/noid/fix-design branch from 132df07 to b95e256 Compare July 8, 2021 23:36
@szaimen

This comment has been minimized.

Sign in to view
@szaimen

This comment has been minimized.

Sign in to view
@szaimen

This comment has been minimized.

Sign in to view
@szaimen

This comment has been minimized.

Sign in to view
@szaimen szaimen requested a review from beardhatcode July 9, 2021 10:47
@szaimen

This comment has been minimized.

Sign in to view
@szaimen szaimen mentioned this pull request Jul 9, 2021
Merged
@szaimen

This comment has been minimized.

Sign in to view
@szaimen szaimen requested a review from artonge July 13, 2021 09:46
@szaimen @artonge
Fix pdfviewer design
e17b570 
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the enh/noid/fix-design branch from b95e256 to e17b570 Compare July 13, 2021 12:21
artonge
artonge approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@szaimen
Copy link
Collaborator Author

szaimen commented Jul 13, 2021

Thanks @artonge for compiling and pushing the js! :)

@szaimen szaimen merged commit 6cc0da0 into master Jul 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/fix-design branch July 13, 2021 12:29
@szaimen
Copy link
Collaborator Author

szaimen commented Jul 13, 2021

/backport to stable22

@szaimen
Copy link
Collaborator Author

szaimen commented Jul 13, 2021

/backport to stable21

@szaimen
Copy link
Collaborator Author

szaimen commented Jul 13, 2021

/backport to stable20

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 13, 2021
Merged
This was referenced Jul 13, 2021
Merged
Merged
@jancborchardt
Copy link
Member

jancborchardt commented Jul 19, 2021

Yeeessss full width and to the bottom! :D Nice work!

@szaimen szaimen mentioned this pull request Oct 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@beardhatcode beardhatcode Awaiting requested review from beardhatcode

Assignees

No one assigned

Labels

3. to review design enhancement

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

No way to close the pdf viewer on mobile/in portrait mode In NC 20.0.0 pdf viewer uses unnecessary black bezels on the sides of a PDF document

5 participants

@szaimen @jancborchardt @artonge @Pytal