Skip to content

Move personal setting to the app#42

Merged
MorrisJobke merged 2 commits into
masterfrom
personal-setting
Jul 4, 2017
Merged

Move personal setting to the app#42
MorrisJobke merged 2 commits into
masterfrom
personal-setting

Conversation

@nickvergessen

@nickvergessen nickvergessen commented Jul 3, 2017 •
edited by MorrisJobke
Loading

Copy link
Copy Markdown
Member

@nickvergessen
Move personal setting to the app
6e34e73 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 13 milestone Jul 3, 2017
@nickvergessen nickvergessen requested a review from blizzz July 3, 2017 10:21
@nickvergessen nickvergessen mentioned this pull request Jul 3, 2017
Merged
1 task
@nickvergessen
Fix typos
2fef8d8 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen

nickvergessen commented Jul 3, 2017

Copy link
Copy Markdown
Member Author

The page of the app is currently very empty.
Anyone has any idea what we could do there? Maybe expand the info we show directly instead of having a button to open the wizard?

@blizzz @MorrisJobke @jancborchardt @jospoortvliet

nextcloud_-_2017-07-03_12 43 21

@jancborchardt

jancborchardt commented Jul 3, 2017

Copy link
Copy Markdown
Member

Yeah, let's definitely put the whole info of the wizard directly there. It also has info on the documentation and syncing Calendar & Contacts. :)

MorrisJobke
MorrisJobke approved these changes Jul 4, 2017
View reviewed changes

@MorrisJobke MorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

blizzz
blizzz approved these changes Jul 4, 2017
View reviewed changes

@blizzz blizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested, works

@MorrisJobke MorrisJobke merged commit 167fd73 into master Jul 4, 2017
@MorrisJobke MorrisJobke deleted the personal-setting branch July 4, 2017 09:38
@nickvergessen nickvergessen mentioned this pull request Jul 4, 2017
Closed
@jancborchardt

jancborchardt commented Jul 4, 2017

Copy link
Copy Markdown
Member

@nickvergessen can you open a follow-up pull request for moving the whole content of the wizard into that settings section? :)

@nickvergessen

nickvergessen commented Jul 5, 2017

Copy link
Copy Markdown
Member Author

See #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes
@blizzz blizzz blizzz approved these changes

Assignees

No one assigned

Labels

4. to release enhancement

Projects

None yet

Milestone

Nextcloud 13

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @jancborchardt @MorrisJobke @blizzz