refactor: Inline most magic methods from CoreRequestBuilder#949
Merged
Conversation
CarlSchwan
force-pushed
the
carl/skim-down-corerequestbuilder
branch
3 times, most recently
from
May 20, 2026 08:22
7f1e83f to
2e091cd
Compare
This depends on deprecated APIs from Doctrine/DBAL Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/skim-down-corerequestbuilder
branch
3 times, most recently
from
May 20, 2026 09:41
60dc2df to
18df0b5
Compare
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/skim-down-corerequestbuilder
branch
from
May 20, 2026 11:21
18df0b5 to
9664d91
Compare
As newer versions are not supported on php 8.1 Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/skim-down-corerequestbuilder
branch
from
June 8, 2026 13:24
f51b0de to
dcc4881
Compare
artonge
approved these changes
Jun 8, 2026
CarlSchwan
force-pushed
the
carl/skim-down-corerequestbuilder
branch
4 times, most recently
from
June 8, 2026 15:21
dd1839f to
be1ca0e
Compare
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
carl/skim-down-corerequestbuilder
branch
from
July 17, 2026 11:05
be1ca0e to
3bf1e7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on deprecated APIs from Doctrine/DBAL and follow more the pattern from other nextcloud apps