fix: another cleanup and linting

charts/nextcloud/Chart.yaml

@@ -1,6 +1,6 @@
 apiVersion: v2
 name: nextcloud
-version: 4.6.1
+version: 4.6.2
 appVersion: 28.0.2
 description: A file sharing server that puts the control and security of your own data back into your hands.
 keywords:

charts/nextcloud/templates/_helpers.tpl

@@ -45,7 +45,7 @@ Create image name that is used in the deployment
 {{- if .Values.image.tag -}}
 {{- printf "%s:%s" .Values.image.repository .Values.image.tag -}}
 {{- else -}}
-{{- printf "%s:%s-%s" .Values.image.repository .Chart.AppVersion (default "apache" .Values.image.flavor) -}}
+{{- printf "%s:%s-%s" .Values.image.repository .Chart.AppVersion .Values.image.flavor -}}
 {{- end -}}
 {{- end -}}
 

charts/nextcloud/templates/db-secret.yaml

@@ -1,5 +1,6 @@
 {{- if or .Values.mariadb.enabled .Values.externalDatabase.enabled .Values.postgresql.enabled }}
 {{- if not .Values.externalDatabase.existingSecret.enabled }}
+---
 apiVersion: v1
 kind: Secret
 metadata:

charts/nextcloud/templates/hpa.yaml

@@ -1,4 +1,5 @@
 {{- if .Values.hpa.enabled }}
+---
 apiVersion: autoscaling/v1
 kind: HorizontalPodAutoscaler
 metadata:

charts/nextcloud/templates/ingress.yaml

@@ -1,4 +1,5 @@
 {{- if .Values.ingress.enabled }}
+---
 apiVersion: {{ include "nextcloud.ingress.apiVersion" . }}
 kind: Ingress
 metadata:
@@ -25,11 +26,11 @@ spec:
       http:
         paths:
           - path: {{ .Values.ingress.path }}
-            {{- if eq (include "nextcloud.ingress.apiVersion" $) "networking.k8s.io/v1" }}
+            {{- if (eq (include "nextcloud.ingress.apiVersion" $) "networking.k8s.io/v1") }}
             pathType: {{ .Values.ingress.pathType }}
             {{- end }}
             backend:
-              {{- if eq (include "nextcloud.ingress.apiVersion" $) "networking.k8s.io/v1" }}
+              {{- if (eq (include "nextcloud.ingress.apiVersion" $) "networking.k8s.io/v1") }}
               service:
                 name: {{ template "nextcloud.fullname" . }}
                 port:

charts/nextcloud/templates/metrics/deployment.yaml

@@ -1,4 +1,5 @@
 {{- if .Values.metrics.enabled }}
+---
 apiVersion: apps/v1
 kind: Deployment
 metadata:
@@ -18,7 +19,8 @@ spec:
       app.kubernetes.io/component: metrics
   template:
     metadata:
-      annotations: {{- toYaml .Values.metrics.podAnnotations | nindent 8 }}
+      annotations:
+        {{- toYaml .Values.metrics.podAnnotations | nindent 8 }}
       labels:
         app.kubernetes.io/name: {{ include "nextcloud.name" . }}
         app.kubernetes.io/instance: {{ .Release.Name }}

charts/nextcloud/templates/metrics/service.yaml

@@ -1,4 +1,5 @@
 {{- if .Values.metrics.enabled }}
+---
 apiVersion: v1
 kind: Service
 metadata:
@@ -11,7 +12,7 @@ metadata:
     app.kubernetes.io/component: metrics
     {{- with .Values.metrics.service.labels }}
     {{- toYaml . | nindent 4 }}
-    {{- end -}}
+    {{- end }}
   {{- with .Values.metrics.service.annotations }}
   annotations:
     {{- toYaml . | nindent 4 }}

charts/nextcloud/templates/metrics/servicemonitor.yaml

@@ -1,4 +1,5 @@
 {{- if and .Values.metrics.enabled .Values.metrics.serviceMonitor.enabled }}
+---
 apiVersion: monitoring.coreos.com/v1
 kind: ServiceMonitor
 metadata:

charts/nextcloud/templates/nextcloud-data-pvc.yaml

@@ -1,4 +1,5 @@
 {{- if and .Values.persistence.enabled .Values.persistence.nextcloudData.enabled (not .Values.persistence.nextcloudData.existingClaim) }}
+---
 kind: PersistentVolumeClaim
 apiVersion: v1
 metadata:

charts/nextcloud/templates/rbac.yaml

@@ -1,4 +1,5 @@
 {{- if .Values.rbac.enabled }}
+---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:

charts/nextcloud/templates/secrets.yaml

@@ -1,4 +1,5 @@
 {{- if not .Values.nextcloud.existingSecret.enabled }}
+---
 apiVersion: v1
 kind: Secret
 metadata:

charts/nextcloud/templates/service.yaml

@@ -1,3 +1,4 @@
+---
 apiVersion: v1
 kind: Service
 metadata:
@@ -10,8 +11,10 @@ metadata:
     app.kubernetes.io/component: app
 spec:
   type: {{ .Values.service.type }}
-  {{- if and (eq .Values.service.type "LoadBalancer") .Values.service.loadBalancerIP }}
-  loadBalancerIP: {{ .Values.service.loadBalancerIP | default "" }}
+  {{- if (eq .Values.service.type "LoadBalancer") }}
+  {{- with .Values.service.loadBalancerIP }}
+  loadBalancerIP: {{ . }}
+  {{- end }}
   {{- end }}
   {{- with .Values.service.ipFamilies }}
   ipFamilies: 
@@ -25,7 +28,7 @@ spec:
       targetPort: {{ .Values.nextcloud.containerPort }}
       protocol: TCP
       name: http
-      {{- if eq .Values.service.type "NodePort" }}
+      {{- if (eq .Values.service.type "NodePort") }}
       nodePort: {{ .Values.service.nodePort | default "" }}
       {{- end }}
   selector:

charts/nextcloud/templates/serviceaccount.yaml

@@ -1,4 +1,5 @@
 {{- if and .Values.rbac.enabled .Values.rbac.serviceaccount.create }}
+---
 apiVersion: v1
 kind: ServiceAccount
 metadata:

charts/nextcloud/values.yaml

@@ -3,7 +3,9 @@
 ##
 image:
   repository: nextcloud
-  # tag: 24.0.3-apache
+  flavor: apache
+  # default is generated by flavor and appVersion
+  tag:
   pullPolicy: IfNotPresent
   # pullSecrets:
   #   - myRegistrKeySecretName