Skip to content

Fix: quote nextcloud.objectStore.s3.legacyAuth value when rendering as env var - #638

Merged
jessebot merged 1 commit into
nextcloud:mainfrom
jessebot:fix-s3-legacy-auth-quotation
Sep 25, 2024
Merged

Fix: quote nextcloud.objectStore.s3.legacyAuth value when rendering as env var#638
jessebot merged 1 commit into
nextcloud:mainfrom
jessebot:fix-s3-legacy-auth-quotation

Conversation

@jessebot

Copy link
Copy Markdown
Collaborator

Description of the change

This quotes the nextcloud.objectStore.s3.legacyAuth value when rendering it as an env var in _helpers.tpl. I think that's why it wasn't working before.

Benefits

Without this fix, setting the value to true doesn't work.

Possible drawbacks

We could also just have it be this to be more explicit, since the with will ignore a value of false anyway:

{{- with .Values.nextcloud.objectStore.s3.legacyAuth }}
- name: OBJECTSTORE_S3_LEGACYAUTH
  value: "true"
{{- end }}

Either should solve the issue 🤷

Applicable issues

Checklist

…s env var

Signed-off-by: jessebot <jessebot@linux.com>
@jessebot jessebot added the S3 Anything to do with S3 object storage label Sep 25, 2024
@jessebot jessebot self-assigned this Sep 25, 2024
@jessebot jessebot added the 3. to review Waiting for reviews label Sep 25, 2024
@jessebot

Copy link
Copy Markdown
Collaborator Author

Thanks for the super fast review! 🙏

@jessebot
jessebot merged commit feaf104 into nextcloud:main Sep 25, 2024
@jessebot
jessebot deleted the fix-s3-legacy-auth-quotation branch September 25, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews S3 Anything to do with S3 object storage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting nextcloud.objectStore.s3.legacyAuth is not being set as string env var

2 participants