feat(nextcloud): allow imagePullSecrets for cronjob - #781
Merged
wrenix merged 2 commits intoOct 4, 2025
Conversation
Signed-off-by: Txomin Itoiz <txomin.itoiz@mazins.fr>
Signed-off-by: WrenIX <133280015+wrenix@users.noreply.github.com>
wrenix
changed the title
wrenix
enabled auto-merge (squash)
October 4, 2025 07:15
ojsef39
pushed a commit
to ojsef39/helm
that referenced
this pull request
Oct 7, 2025
Signed-off-by: Txomin Itoiz <txomin.itoiz@mazins.fr> Signed-off-by: Josef Hofer <me@jhofer.de>
MichaelSp
pushed a commit
to MichaelSp/nextcloud-helm
that referenced
this pull request
Nov 8, 2025
* fix(nextcloud): lower outdated apps prometheus alertrule to info nextcloud#784 Signed-off-by: Josef Hofer <me@jhofer.de> * feat(nextcloud): allow imagePullSecrets for cronjob nextcloud#781 Signed-off-by: Txomin Itoiz <txomin.itoiz@mazins.fr> * feat(nextcloud): add topologySpreadConstraints support nextcloud#782 Signed-off-by: Txomin Itoiz <txomin.itoiz@mazins.fr> * fix(nextcloud): cronjob not working with no $.Values.podLabels set nextcloud#785 wrong type for value; expected map[string]interface {}; got interface {} i think this issue got introduced with nextcloud#779 Signed-off-by: Josef Hofer <me@jhofer.de> * feat(pvc): add extra labels on pvcs nextcloud#793 Signed-off-by: DrummyFloyd <jonathan.monnet28@gmail.com> * fix(nextcloud): update AppVersion to v32.0.1 nextcloud#795 Signed-off-by: WrenIX <133280015+wrenix@users.noreply.github.com> * chore(deps): bump helm/kind-action from 1.12.0 to 1.13.0 Bumps [helm/kind-action](https://github.com/helm/kind-action) from 1.12.0 to 1.13.0. - [Release notes](https://github.com/helm/kind-action/releases) - [Commits](helm/kind-action@v1.12.0...v1.13.0) --- updated-dependencies: - dependency-name: helm/kind-action dependency-version: 1.13.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix(docs): typo in README.md for ipFamilyPolicy nextcloud#796 Signed-off-by: Roger Roger <me@rogerrogert.de> --------- Signed-off-by: Josef Hofer <me@jhofer.de> Signed-off-by: Txomin Itoiz <txomin.itoiz@mazins.fr> Signed-off-by: DrummyFloyd <jonathan.monnet28@gmail.com> Signed-off-by: WrenIX <133280015+wrenix@users.noreply.github.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Roger Roger <me@rogerrogert.de> Co-authored-by: Josef Hofer <me@jhofer.de> Co-authored-by: Mazins <133565773+mazinsfr@users.noreply.github.com> Co-authored-by: DrummyFloyd <jonathan.monnet28@gmail.com> Co-authored-by: WrenIX <133280015+wrenix@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: V Aretakis <vassilis@aretakis.eu> Co-authored-by: Roger Roger <me@rogerrogert.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds imagePullSecrets for cronjob pod.
Benefits
Allows to pull nextcloud image from private registry for cronjob pod.
Possible drawbacks
N/A
Applicable issues
Additional information
Cronjob pod and nextcloud pod should use the same image. So I assume the user uses the same registry for nextcloud pod and cronjob pod.
Checklist
Chart.yamlaccording to semver.