Skip to content

feat(pvc): add extra labels on pvcs #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wrenix merged 1 commit into from
Oct 23, 2025
Merged

feat(pvc): add extra labels on pvcs #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/nextcloud/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: nextcloud
version: 8.4.1
version: 8.5.0
# renovate: image=docker.io/library/nextcloud
appVersion: 32.0.0
description: A file sharing server that puts the control and security of your own data back into your hands.
Expand Down
2 changes: 2 additions & 0 deletions charts/nextcloud/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,12 +392,14 @@ Nextcloud will *not* delete the PVCs when uninstalling the helm chart.
| ----------------------------------------- | ---------------------------------------------------- | --------------- |
| `persistence.enabled` | Enable persistence using PVC | `false` |
| `persistence.annotations` | PVC annotations | `{}` |
| `persistence.labels` | PVC labels | `{}` |
| `persistence.storageClass` | PVC Storage Class for nextcloud volume | `nil` |
| `persistence.existingClaim` | An Existing PVC name for nextcloud volume | `nil` |
| `persistence.accessMode` | PVC Access Mode for nextcloud volume | `ReadWriteOnce` |
| `persistence.size` | PVC Storage Request for nextcloud volume | `8Gi` |
| `persistence.nextcloudData.enabled` | Create a second PVC for the data folder in nextcloud | `false` |
| `persistence.nextcloudData.annotations` | see `persistence.annotations` | `{}` |
| `persistence.nextcloudData.labels` | see `persistence.labels` | `{}` |
| `persistence.nextcloudData.storageClass` | see `persistence.storageClass` | `nil` |
| `persistence.nextcloudData.existingClaim` | see `persistence.existingClaim` | `nil` |
| `persistence.nextcloudData.accessMode` | see `persistence.accessMode` | `ReadWriteOnce` |
Expand Down
3 changes: 3 additions & 0 deletions charts/nextcloud/templates/nextcloud-data-pvc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ metadata:
name: {{ template "nextcloud.fullname" . }}-nextcloud-data
labels:
{{- include "nextcloud.labels" ( dict "component" "app" "rootContext" $ ) | nindent 4 }}
{{- with .Values.persistence.nextcloudData.labels }}
{{- toYaml . | nindent 4 }}
{{- end }}
annotations:
helm.sh/resource-policy: keep
{{- with .Values.persistence.nextcloudData.annotations }}
Expand Down
3 changes: 3 additions & 0 deletions charts/nextcloud/templates/nextcloud-pvc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ metadata:
name: {{ template "nextcloud.fullname" . }}-nextcloud
labels:
{{- include "nextcloud.labels" ( dict "component" "app" "rootContext" $ ) | nindent 4 }}
{{- with .Values.persistence.labels }}
{{- toYaml . | nindent 4 }}
{{- end }}
annotations:
helm.sh/resource-policy: keep
{{- with .Values.persistence.annotations }}
Expand Down
2 changes: 2 additions & 0 deletions charts/nextcloud/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,7 @@ persistence:
# Nextcloud Data (/var/www/html)
enabled: false
annotations: {}
labels: {}
## nextcloud data Persistent Volume Storage Class
## If defined, storageClassName: <storageClass>
## If set to "-", storageClassName: "", which disables dynamic provisioning
Expand All @@ -725,6 +726,7 @@ persistence:
nextcloudData:
enabled: false
subPath:
labels: {}
annotations: {}
# storageClass: "-"
# existingClaim:
Expand Down