disable psalm for nextcloud master#504
Merged
Merged
Conversation
Signed-off-by: Swikriti Tripathi <swikriti808@gmail.com>
675a331 to
a482888
Compare
JS Code CoverageCoverage after merging fix/disable-psalm-in-master into release/2.4 will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
SagarGi
approved these changes
Oct 13, 2023
SagarGi
left a comment
Contributor
There was a problem hiding this comment.
Not to run the psalm i.e in master branch LGTM 👍
Contributor
Author
|
@individual-it we need to merge this with red CI because the fix of api tests is in #502 |
Contributor
Author
Created a work package here https://community.openproject.org/projects/nextcloud-integration/work_packages/details/50516 |
individual-it
approved these changes
Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a pslam error in nextcloud master, on running locally the error is something like
PHP Fatal error: Declaration of Doctrine\Common\Cache\Psr6\CacheItem::get() must be compatible with Psr\Cache\CacheItemInterface::get(): mixed in nextcloud/master/3rdparty/doctrine/cache/lib/Doctrine/Common/Cache/Psr6/CacheItem.php on line 51The psalm for some reason is looking into the 3rdparty app and I couldn't find the way to suppress , I'll make a PR to 3rdparty to fix the errors if possible but till then maybe it's better to not run psalm in nextcloud master