[BREAKING] feat: support nc33 breaking changes #952
+563
−358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
reviewed
Jan 22, 2026
artonge
force-pushed
the
feat/support-nc33-breaking-changes
branch
from
0c9f65d to
abb6961
Compare
artonge
approved these changes
Jan 22, 2026
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Tested and can confirm that the action and sidebar are properly registered.
saw-jan
force-pushed
the
feat/support-nc33-breaking-changes
branch
from
abb6961 to
5715384
Compare
AndyScherzinger
approved these changes
Jan 23, 2026
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> Signed-off-by: Louis Chmn <louis@chmn.me>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan
force-pushed
the
feat/support-nc33-breaking-changes
branch
from
991e5c2 to
a6c4686
Compare
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Member
Member
|
Looking forward to a pre-release published 🚀 |
Collaborator
Author
THank you @AndyScherzinger for the fix. I will make this ready for ready once I confirm that all features are working |
saw-jan
commented
Jan 23, 2026
| // use the sidebar-tab id for the navigation | ||
| fileList.showDetailsView(filename, 'open-project') | ||
| }, | ||
| }) |
Collaborator
Author
There was a problem hiding this comment.
@julien-nc I believe this is the duplication of singleFileAction in filesPlugin/filesPlugin.js file. Is it safe to remove this one?
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
saw-jan
force-pushed
the
feat/support-nc33-breaking-changes
branch
from
feb0f64 to
c23dbf6
Compare
PHP Code CoverageCoverage after merging feat/support-nc33-breaking-changes into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjust to breaking changes in NC 33 files API.
Similar to nextcloud/approval#350 and nextcloud/approval#355
Changes:
@nextcloud/filesto4.0.0-rc.0Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile