Skip to content

Fix error in assistant chat #4026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpivchev merged 3 commits into from
Mar 17, 2026
+11 −9
Merged

Fix error in assistant chat #4026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92438dc
Refactor
mpivchev Mar 9, 2026
9da340b
Merge branch 'master' of https://github.com/nextcloud/ios into fix-er…
mpivchev Mar 10, 2026
b6cabad
WIP
mpivchev Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions iOSClient/Assistant/Chat/NCAssistantChatModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,15 @@ class NCAssistantChatModel {
showRetryResponseGenerationButton = false
currentSession = nil

await loadAllMessages()
currentSession = await checkChatSession(sessionId: selectedConversation.id)
chatMessageTaskId = currentSession?.messageTaskId
await loadAllMessages()
currentSession = await checkChatSession(sessionId: selectedConversation.id)
chatMessageTaskId = currentSession?.messageTaskId

if messages.last?.isFromHuman == true, chatMessageTaskId == nil, isSending == false {
showRetryResponseGenerationButton = true
} else if chatMessageTaskId != nil {
startPollingForResponse()
}
if messages.last?.isFromHuman == true, chatMessageTaskId == nil, isSending == false {
showRetryResponseGenerationButton = true
} else if chatMessageTaskId != nil {
startPollingForResponse()
}
}

func generateChatSession() async {
Expand Down Expand Up @@ -110,7 +110,8 @@ class NCAssistantChatModel {

let result = await NextcloudKit.shared.checkAssistantChatGeneration(taskId: chatMessageTaskId, sessionId: selectedConversation?.id ?? 0, account: ncSession.account)

if result.error != .success {
// API sends expectation failed error (417) when a message is not ready yet. We should continue polling.
if result.error != .success, result.error.errorCode != NCGlobal.shared.errorExpectationFailed {
stopPolling()
await showErrorBanner(windowScene: windowScene, title: "_error_", text: "_assistant_error_generate_response_", errorCode: result.error.errorCode)
return
Expand Down
1 change: 1 addition & 0 deletions iOSClient/NCGlobal.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ final class NCGlobal: Sendable {
let errorConflict: Int = 409
let errorPreconditionFailed: Int = 412
let errorUnsupportedMediaType: Int = 415
let errorExpectationFailed: Int = 417
let errorInternalServerError: Int = 500
let errorMaintenance: Int = 503
let errorQuota: Int = 507
Expand Down
Loading