fix: thread disappearing after refresh

[GretaD]

fixes #9759

to test

1. open mail app on list view
2. open a message
3. refresh

[ChristophWurst]

Will this cause double fetching when you don't refresh the page but navigate from one mailbox to another?

[GretaD]

Will this cause double fetching when you don't refresh the page but navigate from one mailbox to another?

very good point/question. I will add a check to see if the envelopes are already being loaded before making the fetch request.

[kesselb]

I cannot replicate the problem on main and stable3.7 😕

[GVodyanov]

I am testing this out, but am a little confused. On firefox the issue was not reproducible on main. On chromium, reloading the page causes the thread screen to be blank, both on main and with the fix.

[GretaD]

@kesselb did you change anything when you rebased? :D

[kesselb]

I'm not aware 😕

The commits ebb7a3d and b7af783 look pretty much like ebb7a3d.

[kesselb]

On firefox the issue was not reproducible on main.

Same for me.

On chromium, reloading the page causes the thread screen to be blank, both on main and with the fix.

Works over here ;) It's also blank on main, but on this branch the selected thread is shown.

It's a bit odd that Thread depends on data loaded by Mailbox, but Mailbox might not be there. I hope we can restructure that in the future to have a clearer flow.

[kesselb]

Shall we backport to stable4.0 and stable3.7?

[GretaD]

/backport to stable3.7

[GretaD]

/backport to stable4.0