Store the references, in-reply-to and the thread root id#3337
Merged
ChristophWurst merged 1 commit intoJul 6, 2020
Conversation
ChristophWurst
requested review from
PatrycjaPuczko,
gary-kim,
kesselb,
nickvergessen and
rullzer
2 tasks
rullzer
approved these changes
Jul 3, 2020
|
|
||
| $msg->setUid($this->getUid()); | ||
| $msg->setMessageId($this->getMessageId()); | ||
| $msg->setReferences($this->getRawReferences()); |
Member
There was a problem hiding this comment.
I'm just thinking here if it would make sense to split them already and just store it as json or something? Basically process on input. So that you don't have to do it every time afterwards? But just a suggestion.
Member
Author
There was a problem hiding this comment.
yep, I was also thinking about that
Member
Author
There was a problem hiding this comment.
Let's just do that
Member
There was a problem hiding this comment.
But this is the other way around right? Now you still store them flat and process on setting it?
Member
Author
There was a problem hiding this comment.
They are parsed and set once during the insert. What would you like to see different? The layer at which the parsing happens?
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
enhancement/in-reply-to-references-thread-id
branch
from
bbf8e42 to
dc2cd0c
Compare
rullzer
approved these changes
Jul 6, 2020
|
|
||
| $msg->setUid($this->getUid()); | ||
| $msg->setMessageId($this->getMessageId()); | ||
| $msg->setReferences($this->getRawReferences()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #17, extracted from #2125.
This stores the raw values of
In-Reply-ToandReferencesin the database as well as theMessage-IDof the root element of a message thread. The default is the own (but parsed) message-id, like if the message was its own root. In a follow-up PR I'll finish the algorithm (possibly in #2125) to update this reference if a new root is found. The goal is to have the root as stable as possible and the threading algorithm should make that possible in most cases, we we only have to update this field once.@nextcloud/mail please review
Steps to test