Skip to content

Respect allow/disallow group sharing setting in group service#4785

Merged
ChristophWurst merged 1 commit into
masterfrom
respect-allow-group-sharing-setting
Mar 29, 2021
Merged

Respect allow/disallow group sharing setting in group service#4785
ChristophWurst merged 1 commit into
masterfrom
respect-allow-group-sharing-setting

Conversation

@tcitworld

Copy link
Copy Markdown
Member

Some instances don't want to allow sending emails to everyone in a group.

@welcome

welcome Bot commented Mar 19, 2021

Copy link
Copy Markdown

Thanks for opening your first pull request in this repository! ✌️

@miaulalala miaulalala force-pushed the respect-allow-group-sharing-setting branch from 317b820 to 6eca4ee Compare March 22, 2021 10:41
Some instances don't want to allow sending emails to everyone in a group

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@ChristophWurst ChristophWurst force-pushed the respect-allow-group-sharing-setting branch from 6eca4ee to b58dd9e Compare March 23, 2021 11:33
@ChristophWurst ChristophWurst added this to the v1.10.0 milestone Mar 23, 2021
@ChristophWurst

Copy link
Copy Markdown
Member

/backport to stable1.9

@myrho

myrho commented Mar 26, 2021

Copy link
Copy Markdown
Collaborator

Trying to make dev-setup but it fails at kwi/urllinker:

  - Installing kwi/urllinker (dev-bleeding bc54f1a): Cloning bc54f1afe6
Cloning failed using an ssh key for authentication, enter your GitHub credentials to access private repos

The repo is not public. How to install that? This is related to mail app installation in gen. I think.

@myrho

myrho commented Mar 26, 2021

Copy link
Copy Markdown
Collaborator

I had the same issue one year before: #2972

@ChristophWurst

Copy link
Copy Markdown
Member
  • Installing kwi/urllinker (dev-bleeding bc54f1a): Cloning bc54f1afe6
    Cloning failed using an ssh key for authentication, enter your GitHub credentials to access private repos

https://bitbucket.org/kwi/urllinker was deleted. https://github.com/youthweb/urllinker is a fork that duckduckgo found for me. We could try to switch over.

@myrho

myrho commented Mar 26, 2021

Copy link
Copy Markdown
Collaborator

Finally made it to install the app. Looks fine, works as expected.

@Art4

Art4 commented Dec 6, 2022

Copy link
Copy Markdown
Contributor

Hi, I'm the maintainer of youthweb/urllinker and I just found out that you are using my library in Nextcloud. 😄 I'm glad that my work is used by such a great product that I use myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants