Skip to content

Remove unused repository in composer.json#7771

Merged
kesselb merged 4 commits into
nextcloud:mainfrom
Art4:patch-1
Dec 21, 2022
Merged

Remove unused repository in composer.json#7771
kesselb merged 4 commits into
nextcloud:mainfrom
Art4:patch-1

Conversation

@Art4

@Art4 Art4 commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

The youthweb/urllinker library is now fully typed in the latest version. Since adding return types to interface methods is a breaking change, the major version has been raised. In addition, deprecated methods have been removed, but they are not used in nextcloud/mails. Therefore, further changes are not necessary.

Full changelog:

from https://github.com/youthweb/urllinker/blob/2.0.0/CHANGELOG.md

2.0.0 - 2022-12-14

Changed

  • UrlLinker is now fully typed.
  • BREAKING Return type string was added to method Youthweb\UrlLinker\UrlLinkerInterface::linkUrlsAndEscapeHtml().
  • BREAKING Return type string was added to method Youthweb\UrlLinker\UrlLinkerInterface::linkUrlsInTrustedHtml().

Removed

  • BREAKING The deprecated support for callable in the config option htmlLinkCreator was removed, provide Closure instead
  • BREAKING The deprecated support for callable in the config option emailLinkCreator was removed, provide Closure instead
  • BREAKING The deprecated support for non-boolean in the config option allowFtpAddresses was removed, provide boolean instead
  • BREAKING The deprecated support for non-boolean in the config option allowUpperCaseUrlSchemes was removed, provide boolean instead
  • BREAKING The deprecated method Youthweb\UrlLinker\UrlLinker::getAllowFtpAddresses() was removed
  • BREAKING The deprecated method Youthweb\UrlLinker\UrlLinker::setAllowFtpAddresses() was removed
  • BREAKING The deprecated method Youthweb\UrlLinker\UrlLinker::getAllowUpperCaseUrlSchemes() was removed
  • BREAKING The deprecated method Youthweb\UrlLinker\UrlLinker::setAllowUpperCaseUrlSchemes() was removed
  • BREAKING The deprecated method Youthweb\UrlLinker\UrlLinker::getHtmlLinkCreator() was removed
  • BREAKING The deprecated method Youthweb\UrlLinker\UrlLinker::setHtmlLinkCreator() was removed
  • BREAKING The deprecated method Youthweb\UrlLinker\UrlLinker::getEmailLinkCreator() was removed
  • BREAKING The deprecated method Youthweb\UrlLinker\UrlLinker::setEmailLinkCreator() was removed
  • BREAKING The deprecated method Youthweb\UrlLinker\UrlLinker::getValidTlds() was removed
  • BREAKING The deprecated method Youthweb\UrlLinker\UrlLinker::setValidTlds() was removed

@welcome

welcome Bot commented Dec 15, 2022

Copy link
Copy Markdown

Thanks for opening your first pull request in this repository! ✌️

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@Art4

Art4 commented Dec 15, 2022

Copy link
Copy Markdown
Contributor Author

Looks like I have to update the composer.lock file too.

Comment thread composer.lock
Art4 and others added 3 commits December 15, 2022 10:56
Signed-off-by: Artur Weigandt <Art4@users.noreply.github.com>
Signed-off-by: Art4 <art4@wlabs.de>
Signed-off-by: Art4 <art4@wlabs.de>
Signed-off-by: Art4 <art4@wlabs.de>
@Art4

Art4 commented Dec 15, 2022

Copy link
Copy Markdown
Contributor Author

I've updated the composer.lock file and also removed the unused repository in composer.json. The dependency to this repo was removed in #4836.

And I think #2028 can be closed.

@Art4

Art4 commented Dec 21, 2022

Copy link
Copy Markdown
Contributor Author

This PR was superseded by #7781, leaving only the removal of unused code in the composer.json.

@Art4 Art4 changed the title Bump youthweb/urllinker from 1.5.1 to 2.0.0 Remove unused repository in composer.json Dec 21, 2022

@kesselb kesselb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@kesselb kesselb merged commit 5a6c047 into nextcloud:main Dec 21, 2022
@Art4 Art4 deleted the patch-1 branch June 18, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants