Autocomplete nextcloud groups #41#800
Closed
myrho wants to merge 6 commits into
Closed
Conversation
ChristophWurst
requested changes
Feb 23, 2018
ChristophWurst
left a comment
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Looks good so far!
Please fix the coding style by using spaces instead of tabs and revert the file permission changes, e.g. of
appinfo/app.php 100755 → 100644
| 'value' => $g->getDisplayName(), | ||
| 'photo' => null, | ||
| ]; | ||
| } |
| ->getMock(); | ||
|
|
||
| $this->service = new AutoCompleteService($this->contactsIntegration, | ||
| $this->groupsIntegration, |
| $john, | ||
| ]; | ||
|
|
||
| $groupsResult = [ |
| public function testGetMatchingGroups() { | ||
| $term = 'te'; // searching for: John Doe | ||
| $searchResult = [ | ||
| $this->createTestGroup('testgroup', 'first test group'), |
| ->with($term) | ||
| ->will($this->returnValue($searchResult)); | ||
|
|
||
| $expected = [ |
myrho
force-pushed
the
autocomplete-groups
branch
from
8344ad1 to
e10a2a9
Compare
Collaborator
Author
|
fixed indentation and file permissions via forced push (hope that worked). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autocomplete nextcloud groups in recipient fields