Skip to content

Add .github/copilot-instructions.md for coding agent onboarding#3429

Merged
Grotax merged 4 commits into
masterfrom
copilot/add-copilot-instructions-file
Nov 14, 2025
Merged

Add .github/copilot-instructions.md for coding agent onboarding#3429
Grotax merged 4 commits into
masterfrom
copilot/add-copilot-instructions-file

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 13, 2025

  • Resolves: N/A

Summary

Adds comprehensive instructions for coding agents working with this repository. Reduces exploration time and common CI failures by documenting build sequences, architecture, test requirements, and project-specific workflows.

Key sections:

  • Build instructions: Validated command sequences with timing. Highlights PHP-Scoper dependency workflow (unique to this project - namespaces all vendor deps under OCA\News\Vendor\ to prevent conflicts).
  • Architecture: Directory structure, config file locations, auto-generated vs source directories.
  • Developer environment setup: Three setup options (Docker, DevContainer, Manual) with step-by-step instructions for setting up Nextcloud server to run PHP tests and integration tests.
  • Testing: JS/PHP/integration test commands. Notes which tests require full Nextcloud server setup and how to run them.
  • CI/CD workflows: All 9 GitHub checks documented, including changelog enforcement requirement.
  • Common pitfalls: Node version mismatches, missing scoped dependencies, forgotten changelog updates.
  • Quick reference: Command table with measured execution times.

All commands validated in current environment. File size: 388 lines (~14KB), fits within reasonable limits.

Checklist

Original prompt

Your task is to "onboard" this repository to Copilot coding agent by adding a .github/copilot-instructions.md file in the repository that contains information describing how a coding agent seeing it for the first time can work most efficiently.

You will do this task only one time per repository and doing a good job can SIGNIFICANTLY improve the quality of the agent's work, so take your time, think carefully, and search thoroughly before writing the instructions.

- Reduce the likelihood of a coding agent pull request getting rejected by the user due to generating code that fails the continuous integration build, fails a validation pipeline, or having misbehavior. - Minimize bash command and build failures. - Allow the agent to complete its task more quickly by minimizing the need for exploration using grep, find, str_replace_editor, and code search tools. - Instructions must be no longer than 2 pages. - Instructions must not be task specific.

Add the following high level details about the codebase to reduce the amount of searching the agent has to do to understand the codebase each time:

  • A summary of what the repository does.
  • High level repository information, such as the size of the repo, the type of the project, the languages, frameworks, or target runtimes in use.

Add information about how to build and validate changes so the agent does not need to search and find it each time.

  • For each of bootstrap, build, test, run, lint, and any other scripted step, document the sequence of steps to take to run it successfully as well as the versions of any runtime or build tools used.
  • Each command should be validated by running it to ensure that it works correctly as well as any preconditions and postconditions.
  • Try cleaning the repo and environment and running commands in different orders and document errors and and misbehavior observed as well as any steps used to mitigate the problem.
  • Run the tests and document the order of steps required to run the tests.
  • Make a change to the codebase. Document any unexpected build issues as well as the workarounds.
  • Document environment setup steps that seem optional but that you have validated are actually required.
  • Document the time required for commands that failed due to timing out.
  • When you find a sequence of commands that work for a particular purpose, document them in detail.
  • Use language to indicate when something should always be done. For example: "always run npm install before building".
  • Record any validation steps from documentation.

List key facts about the layout and architecture of the codebase to help the agent find where to make changes with minimal searching.

  • A description of the major architectural elements of the project, including the relative paths to the main project files, the location
    of configuration files for linting, compilation, testing, and preferences.
  • A description of the checks run prior to check in, including any GitHub workflows, continuous integration builds, or other validation pipelines.
  • Document the steps so that the agent can replicate these itself.
  • Any explicit validation steps that the agent can consider to have further confidence in its changes.
  • Dependencies that aren't obvious from the layout or file structure.
  • Finally, fill in any remaining space with detailed lists of the following, in order of priority: the list of files in the repo root, the
    contents of the README, the contents of any key source files, the list of files in the next level down of directories, giving priority to the more structurally important and snippets of code from key source files, such as the one containing the main method.
- Perform a comprehensive inventory of the codebase. Search for and view: - README.md, CONTRIBUTING.md, and all other documentation files. - Search the codebase for build steps and indications of workarounds like 'HACK', 'TODO', etc. - All scripts, particularly those pertaining to build and repo or environment setup. - All build and actions pipelines. - All project files. - All configuration and linting files. - For each file: - think: are the contents or the existence of the file information that the coding agent will need to implement, build, test, validate, or demo a code change? - If yes: - Document the command or information in detail. - Explicitly indicate which commands work and which do not and the order in which commands should be run. - Document any errors encountered as well as the steps taken to workaround them. - Document any other steps or information that the agent can use to reduce time spent exploring or trying and failing to run bash commands. - Finally, explicitly instruct the agent to trust the instructions and only perform a search if the information in the instruction...

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: Grotax <5429298+Grotax@users.noreply.github.com>
Copilot AI changed the title [WIP] Add Copilot instructions for efficient onboarding Add .github/copilot-instructions.md for coding agent onboarding Nov 13, 2025
Copilot AI requested a review from Grotax November 13, 2025 20:02
@Grotax
Copy link
Copy Markdown
Member

Grotax commented Nov 13, 2025

@copilot I think you should add instructions how to do a proper setup with nextcloud so that copilot can actually run the tests because it is not explained in the file. There are instructions in /docs

…tructions.md

Co-authored-by: Grotax <5429298+Grotax@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Nov 13, 2025

@copilot I think you should add instructions how to do a proper setup with nextcloud so that copilot can actually run the tests because it is not explained in the file. There are instructions in /doc...

Added a comprehensive "Developer Environment Setup" section with three setup options (Docker, DevContainer, Manual) and detailed instructions for running PHP tests with Nextcloud. The section includes step-by-step commands for each approach and references to existing docs for more details. See commit 919e689.

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax requested a review from Copilot November 14, 2025 14:51
@Grotax Grotax added the Skip-Changelog No changelog update is required, minor change label Nov 14, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive onboarding documentation for coding agents working with the Nextcloud News repository. The goal is to reduce exploration time, minimize CI failures, and improve the quality of agent-generated code by providing detailed build instructions, architecture overview, and common workflows.

Key changes:

  • Adds .github/copilot-instructions.md with 405 lines of validated instructions
  • Updates composer.lock to upgrade php-feed-io/feed-io dependency from v6.1.2 to v6.2.0
  • Documents unique PHP-Scoper workflow, all 9 CI checks, three setup options, and common pitfalls

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
.github/copilot-instructions.md New comprehensive coding agent instructions covering build sequences, architecture, testing, CI workflows, and common pitfalls with validated commands and timing information
composer.lock Updates php-feed-io/feed-io dependency from v6.1.2 to v6.2.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Grotax Grotax marked this pull request as ready for review November 14, 2025 15:05
@Grotax Grotax merged commit b700b8d into master Nov 14, 2025
32 of 35 checks passed
@Grotax Grotax deleted the copilot/add-copilot-instructions-file branch November 14, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip-Changelog No changelog update is required, minor change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants