Skip to content

fix: changing starred routes does not deselect current item#3502

Merged
Grotax merged 1 commit into
nextcloud:masterfrom
wofferl:fix_starred_feed_switch
Jan 12, 2026
Merged

fix: changing starred routes does not deselect current item#3502
Grotax merged 1 commit into
nextcloud:masterfrom
wofferl:fix_starred_feed_switch

Conversation

@wofferl
Copy link
Copy Markdown
Collaborator

@wofferl wofferl commented Jan 11, 2026

Summary

This PR contains a small bug fix for the starred route feature #3148

Since the starred route now has multiple routes it needs a unique key otherwise things like deselecting the current viewed article from the last selected route wont work.

Checklist

Signed-off-by: Wolfgang <github@linux-dude.de>
@wofferl wofferl added 3. to review frontend impact Javascript/Frontend code Skip-Changelog No changelog update is required, minor change labels Jan 11, 2026
@wofferl wofferl changed the title fix: add unique key to ensure proper re-rendering fix: changing starred routes do not deselect current item Jan 11, 2026
@wofferl wofferl changed the title fix: changing starred routes do not deselect current item fix: changing starred routes does not deselect current item Jan 11, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Grotax Grotax merged commit 30d509f into nextcloud:master Jan 12, 2026
38 of 39 checks passed
@wofferl wofferl deleted the fix_starred_feed_switch branch January 27, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review frontend impact Javascript/Frontend code Skip-Changelog No changelog update is required, minor change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants