Add hint to settings#24
Merged
Merged
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Member
|
We didn't use this atm, new versions are not handled by this thing, but the update notifications app. |
Member
Author
|
@nickvergessen if I add a hint to that app then, would the text I proposed above work? |
Member
|
Well I don't know what the app is planned to be used for, so no idea |
Member
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding more hints to settings, ref nextcloud/server#4478 nextcloud/server#4540
Please review @karlitschek @nickvergessen @MorrisJobke
I would like to also clarify what exactly is shown. Like
Or whatever it’s used for. That’s unclear in the readme and we should add it because initially it sounds like blogspam.