Show icon if a note is not synchronized (hint to a possible error)#121
Closed
korelstar wants to merge 4 commits into
Closed
Show icon if a note is not synchronized (hint to a possible error)#121korelstar wants to merge 4 commits into
korelstar wants to merge 4 commits into
Conversation
…String sql, String[] selectionArgs) New method getLocalModifiedNotes() is a preparation for bugfixing #117
Member
|
hm, okay, i'll have to check and test this locally, could take some time, sorry. |
Member
Author
|
Oh, that's a nice website. Didn't know it. I've updated the icons now. |
Member
Author
|
Okay, my fix for #117 is nearly finished, so all changes done here will be in the next pull request. So I close this one, since the refactoring done here was not perfect. However, comments are welcome and feedback will be integrated into the upcoming pull request. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new icon which is shown on the right margin of a
Notein theNoteListViewActivityif (and only if) the note is not synchronized, i.e., the note is new or was edited and the respective data is only local and not yet on the server side. This gives a hint to check, if there is a problem with the synchronization (partly closes #119). Until now, if synchronization fails, one can't realize this and somebody may think everything is fine.The implementation introduces the new model
DBNotewhich extendsNotewith thestatusattribute in order to display the status of the note. The icons come from the original android settings app: https://github.com/android/platform_packages_apps_settings