Change category#210
Merged
Merged
Conversation
korelstar
force-pushed
the
change-category
branch
from
7d1f1ae to
f83bf35
Compare
Member
|
@korelstar if you can fix the conflicts, i would like to merge this, too. time to get active again ;-) ! |
Member
Author
|
Did you test this? In my emulator, there was an issue regarding the color of the save and cancel button in the dialog for changing the category (it's nearly transparent). Do you have any idea, where this come from and how to fix this (maybe a problem with the theme)? Regarding the conflicts: I have no time for this today, but I can do it in the next days. |
korelstar
force-pushed
the
change-category
branch
from
f83bf35 to
8a403f3
Compare
Member
Author
|
The button color problem disappeared (maybe due to an update of my emulator or used libraries) and the conflicts are resolved. Hence, from my side, this can be merged. You can get active again! ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple interface for category change. The latest release of the server app doesn't support changing categories, but there is already as PR: nextcloud/notes#87. Until those changes are merged and released, this pull request may stay unmerged and intended just for information about the progress. However, please feel free to test this!