Reworked single note widget#297
Closed
dan0xii wants to merge 1 commit into
Closed
Conversation
dan0xii
force-pushed
the
snw_deleted_note
branch
from
0a102b8 to
5da1165
Compare
Member
|
Looks like you've downgraded the git submodule cert4android (by accident?). Due to that, the build fails. Please remove the cert4android-change from the pull request. |
The widget will now check to see if the note exists before trying to display it. Fixes nextcloud#293. Moved opening of db from getViewAt. Fixed the widget's empty view.
dan0xii
force-pushed
the
snw_deleted_note
branch
from
5da1165 to
eb6a44d
Compare
Collaborator
Author
|
That was unintentional. I think I've sorted it now. |
Merged
Member
|
Quick code review looks good to me, will test it soon. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The widget will now check to see if the note exists before trying to display it. Fixes #293.