Also show notes inside subdirectories

[Henni]

First step towards owncloud/notes#2

TODO:

• Fix (Maybe rewrite) tests

[Henni]

Seems like a transifex update from owncloud snuck in. I'll "force-fix" this.

[korelstar]

Nice! I'm really looking forward to this feature.

Do you plan a "silent" integration of subdirs (the source of the note is omitted, they are all shown in one list of notes) or should the subdirs be shown in the GUI as "folders" (like a contact group in the contacts app)? The second variant would directly influence #2, because the navigation sidebar could then show the list of folders instead the list of notes and a second sidebar could be needed (like in the contacts app). I like that concept because it would be possible to structure the notes in a better way.

/cc @jancborchardt

[Henni]

For now it is "silent".
The goal is to create some kind of structure (categorization) with the help of subdirectories.
But I'd prefer to keep it simple and maybe integrate it into the already existing sidebar. (let's talk about this in #8)

[jancborchardt]

CC'ing the people who were involved in the discussion on subfolders for Notes in the original issue. :) You’ll probably like that work is being done on it here! 🎉

Reviews are very welcome!
@caco3 @pyluyten @lpalgarvio @reimersjan @slashrsm @Jas2Ma @grefel @pierrejochem @greenais @rakshazi @sprnza @pbek @olantrust @xraMsamohT @dasmaetthes @jibweb

[dasmaetthes]

Very nice,
Would it work also with owncloud or nextcloud only?

[jancborchardt]

@dasmaetthes it will likely work with ownCloud as well for the near future. However as most people developing on these apps (also like Calendar, Contacts and Mail) moved to Nextcloud and don’t necessarily test with both systems, bugs could occur in the future. So we recommend to upgrade. :)

[Henni]

@dasmaetthes should work with owncloud as well. Tests on owncloud are welcome :)

[dasmaetthes]

Seems to work well with owncloud. If I will find any bug later will open a new issue.

Thank you very much.

[nogweii]

Just wondering if there is anything blocking this from being merged?

[Henni]

@evaryont the tests should be fixed before merging this.

[korelstar]

@Henni
I've fixed the tests, rebased the branch and added a new attribute category for the Note entity which is filled with the subdir name. I suggest to merge this now since some people are waiting for this impatiently ... 😁

[Henni]

I removed two debug lines which I left in.

After travis has finished I'll merge this and release notes 2.2

[jancborchardt]

Awesome work! :) 🎉